README.md - Issue 29808587: Issue 6717 - Part 1: run eslint through npm

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: README.md

Issue 29808587: Issue 6717 - Part 1: run eslint through npm (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/

Left Patch Set: Use eslint4 and eyeo eslint 2.0.0. Rename task to "lint" Created July 13, 2018, 2:14 p.m.

Right Patch Set: Require eslint-config-eyeo 2.1.0 Created Aug. 14, 2018, 11:36 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 Adblock Plus for Chrome, Opera, Microsoft Edge and Firefox	1 Adblock Plus for Chrome, Opera, Microsoft Edge and Firefox

2 ==========================================================	2 ==========================================================

3	3

4 This repository contains the platform-specific Adblock Plus source code for	4 This repository contains the platform-specific Adblock Plus source code for

5 Chrome, Opera, Microsoft Edge and Firefox. It can be used to build	5 Chrome, Opera, Microsoft Edge and Firefox. It can be used to build

6 Adblock Plus for these platforms, generic Adblock Plus code will be extracted	6 Adblock Plus for these platforms, generic Adblock Plus code will be extracted

7 from other repositories automatically (see _dependencies_ file).	7 from other repositories automatically (see _dependencies_ file).

8	8

9 Note that the Firefox extension built from this repository is the new	9 Note that the Firefox extension built from this repository is the new

10 [WebExtension](https://developer.mozilla.org/en-US/Add-ons/WebExtensions).	10 [WebExtension](https://developer.mozilla.org/en-US/Add-ons/WebExtensions).

(...skipping 74 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
85	85

86 location.href = "qunit/index.html";	86 location.href = "qunit/index.html";

87	87

88 The unit tests will run automatically once the page loads.	88 The unit tests will run automatically once the page loads.

89	89

90 Linting	90 Linting

91 -------	91 -------

92	92

93 You can lint the code using [ESLint](http://eslint.org).	93 You can lint the code using [ESLint](http://eslint.org).

94	94

	95 You will need to setup first. This will install our configuration

	96 [eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/tip/eslint-conf ig-eyeo)

	97 and everything needed after you run:

	98

	99 npm install

	100

	101 Then you can run to lint the code:

	102

95 npm run lint	103 npm run lint

96	104

97 You will need to run at first

98

99 npm install

LEFT	RIGHT