package.json - Issue 29808587: Issue 6717 - Part 1: run eslint through npm

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: package.json

Issue 29808587: Issue 6717 - Part 1: run eslint through npm (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/

Left Patch Set: Use eslint4 and eyeo eslint 2.0.0. Rename task to "lint" Created July 13, 2018, 2:14 p.m.

Right Patch Set: Require eslint-config-eyeo 2.1.0 Created Aug. 14, 2018, 11:36 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 {	1 {

2 "name": "adblockpluschrome",	2 "name": "adblockpluschrome",

3 "repository": "https://hg.adblockplus.org/adblockpluschrome",	3 "repository": "https://hg.adblockplus.org/adblockpluschrome",

4 "license": "GPL-3.0",	4 "license": "GPL-3.0",

5 "dependencies": {},	5 "dependencies": {},

6 "devDependencies": {	6 "devDependencies": {

7 "eslint": "^4.19.0",	7 "eslint": "^5.1.0",
Sebastian Noack 2018/07/13 15:04:08 We want to update to ESLint 5, don't we? Moreover, We want to update to ESLint 5, don't we? Moreover, is it even necessary to redundantly specify the eslint version here, since it's already given as peerDependency in eslint-config-eyeo? hub 2018/07/13 15:05:47 I have moved on to ^5.1.0. When the peerDependency Show quoted text On 2018/07/13 15:04:08, Sebastian Noack wrote: > We want to update to ESLint 5, don't we? Moreover, is it even necessary to > redundantly specify the eslint version here, since it's already given as > peerDependency in eslint-config-eyeo? I have moved on to ^5.1.0. When the peerDependency in eslint-config-eyeo, we can ditch it here. Sebastian Noack 2018/07/13 15:08:26 Let's update eslint-config-eyeo [1] first, so that Show quoted text On 2018/07/13 15:05:47, hub wrote: > On 2018/07/13 15:04:08, Sebastian Noack wrote: > > We want to update to ESLint 5, don't we? Moreover, is it even necessary to > > redundantly specify the eslint version here, since it's already given as > > peerDependency in eslint-config-eyeo? > > I have moved on to ^5.1.0. > When the peerDependency in eslint-config-eyeo, we can ditch it here. Let's update eslint-config-eyeo [1] first, so that we don't need to change the configuration here twice. [1]: https://hg.adblockplus.org/codingtools/file/master/eslint-config-eyeo hub 2018/07/13 16:12:43 Acknowledged. Show quoted text On 2018/07/13 15:08:26, Sebastian Noack wrote: > On 2018/07/13 15:05:47, hub wrote: > > On 2018/07/13 15:04:08, Sebastian Noack wrote: > > > We want to update to ESLint 5, don't we? Moreover, is it even necessary to > > > redundantly specify the eslint version here, since it's already given as > > > peerDependency in eslint-config-eyeo? > > > > I have moved on to ^5.1.0. > > When the peerDependency in eslint-config-eyeo, we can ditch it here. > > Let's update eslint-config-eyeo [1] first, so that we don't need to change the > configuration here twice. > > [1]: https://hg.adblockplus.org/codingtools/file/master/eslint-config-eyeo Acknowledged. Sebastian Noack 2018/08/14 19:16:55 What is about this comment? Show quoted text On 2018/07/13 15:04:08, Sebastian Noack wrote: > [...] is it even necessary to redundantly specify > the eslint version here, since it's already given as > peerDependency in eslint-config-eyeo? What is about this comment? hub 2018/08/14 19:35:16 it is needed. Without it, I get: ```` $ npm insta Show quoted text On 2018/08/14 19:16:55, Sebastian Noack wrote: > On 2018/07/13 15:04:08, Sebastian Noack wrote: > > [...] is it even necessary to redundantly specify > > the eslint version here, since it's already given as > > peerDependency in eslint-config-eyeo? > > What is about this comment? it is needed. Without it, I get: ```` $ npm install added 1 package in 0.648s [ no eslint installed ] $ npm install npm WARN eslint-config-eyeo@2.1.0 requires a peer of eslint@^5.1 but none was installed. up to date in 0.083s ```` If I add it, all is good.
8 "eslint-config-eyeo": "2.0.0"	8 "eslint-config-eyeo": "^2.1.0"

9 },	9 },

10 "scripts": {	10 "scripts": {

11 "lint": "eslint *.js lib/ qunit/ ext/",	11 "lint": "eslint *.js lib/ qunit/ ext/",

12 "posttest": "npm run lint"	12 "posttest": "npm run lint"

13 }	13 }

14 }	14 }

LEFT	RIGHT