Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: README.md

Issue 29808587: Issue 6717 - Part 1: run eslint through npm (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/
Left Patch Set: Use eslint5. Fix eslint error. Created July 13, 2018, 3:04 p.m.
Right Patch Set: Require eslint-config-eyeo 2.1.0 Created Aug. 14, 2018, 11:36 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « .hgignore ('k') | ext/background.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 Adblock Plus for Chrome, Opera, Microsoft Edge and Firefox 1 Adblock Plus for Chrome, Opera, Microsoft Edge and Firefox
2 ========================================================== 2 ==========================================================
3 3
4 This repository contains the platform-specific Adblock Plus source code for 4 This repository contains the platform-specific Adblock Plus source code for
5 Chrome, Opera, Microsoft Edge and Firefox. It can be used to build 5 Chrome, Opera, Microsoft Edge and Firefox. It can be used to build
6 Adblock Plus for these platforms, generic Adblock Plus code will be extracted 6 Adblock Plus for these platforms, generic Adblock Plus code will be extracted
7 from other repositories automatically (see _dependencies_ file). 7 from other repositories automatically (see _dependencies_ file).
8 8
9 Note that the Firefox extension built from this repository is the new 9 Note that the Firefox extension built from this repository is the new
10 [WebExtension](https://developer.mozilla.org/en-US/Add-ons/WebExtensions). 10 [WebExtension](https://developer.mozilla.org/en-US/Add-ons/WebExtensions).
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 directory of the repository. In order to run the unit tests go to the 83 directory of the repository. In order to run the unit tests go to the
84 extension's Options page, open the JavaScript Console and type in: 84 extension's Options page, open the JavaScript Console and type in:
85 85
86 location.href = "qunit/index.html"; 86 location.href = "qunit/index.html";
87 87
88 The unit tests will run automatically once the page loads. 88 The unit tests will run automatically once the page loads.
89 89
90 Linting 90 Linting
91 ------- 91 -------
92 92
93 You can lint the code using [ESLint](http://eslint.org). 93 You can lint the code using [ESLint](http://eslint.org).
kzar 2018/08/08 11:15:19 Would you mind adding a link to our configuration
hub 2018/08/14 11:37:03 reworded a bit the whole paragraph and added the l
94 94
95 You will need to setup first. This will install our configuration
96 [eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/tip/eslint-conf ig-eyeo)
97 and everything needed after you run:
98
99 npm install
100
101 Then you can run to lint the code:
102
95 npm run lint 103 npm run lint
96 104
97 You will need to run at first
98
99 npm install
LEFTRIGHT

Powered by Google App Engine
This is Rietveld