Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: ext/background.js

Issue 29808587: Issue 6717 - Part 1: run eslint through npm (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/
Patch Set: Use eslint5. Fix eslint error. Created July 13, 2018, 3:04 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« README.md ('K') | « README.md ('k') | package.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ext/background.js
===================================================================
--- a/ext/background.js
+++ b/ext/background.js
@@ -90,16 +90,18 @@
// the onBeforeRequest handler.
let frames = framesOfTabs.get(this.id);
if (frames)
{
let frame = frames.get(0);
if (frame)
return frame.url;
}
+
+ return undefined;
kzar 2018/08/08 11:15:19 This looks like an unrelated change? If not could
hub 2018/08/14 11:37:03 Without it eslint show an error 81:12 error E
},
sendMessage(message, responseCallback)
{
browser.tabs.sendMessage(this.id, message, responseCallback);
}
};
ext.getPage = id => new Page({id: parseInt(id, 10)});
« README.md ('K') | « README.md ('k') | package.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld