Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/FileSystemJsObject.cpp

Issue 29810573: Issue 6526 - Remove deprecated Utf8Value() usage (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: Created June 19, 2018, 5:11 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ConsoleJsObject.cpp ('k') | src/JsEngine.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/FileSystemJsObject.cpp
===================================================================
--- a/src/FileSystemJsObject.cpp
+++ b/src/FileSystemJsObject.cpp
@@ -183,17 +183,18 @@
const auto contentEnd = content.cend();
auto stringBegin = SkipEndOfLine(content.begin(), contentEnd);
do
{
auto stringEnd = AdvanceToEndOfLine(stringBegin, contentEnd);
auto jsLine = Utils::StringBufferToV8String(jsEngine->GetIsolate(), StringBuffer(stringBegin, stringEnd)).As<v8::Value>();
processFunc->Call(globalContext, 1, &jsLine);
if (tryCatch.HasCaught())
- throw JsError(tryCatch.Exception(), tryCatch.Message());
+ throw JsError(jsEngine->GetIsolate(), tryCatch.Exception(),
+ tryCatch.Message());
stringBegin = SkipEndOfLine(stringEnd, contentEnd);
} while (stringBegin != contentEnd);
jsEngine->GetJsValues(weakData->weakResolveCallback)[0].Call();
}, [weakData](const std::string& error)
{
if (error.empty())
return;
auto jsEngine = weakData->weakJsEngine.lock();
« no previous file with comments | « src/ConsoleJsObject.cpp ('k') | src/JsEngine.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld