Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: src/JsError.cpp

Issue 29810583: Issue 6526 - Use new v8::Message::GetLineNumber() API (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: Created June 19, 2018, 5:13 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 18 matching lines...) Expand all
29 const v8::Local<v8::Value>& exception, 29 const v8::Local<v8::Value>& exception,
30 const v8::Local<v8::Message>& message) 30 const v8::Local<v8::Message>& message)
31 { 31 {
32 std::stringstream error; 32 std::stringstream error;
33 error << *v8::String::Utf8Value(isolate, exception); 33 error << *v8::String::Utf8Value(isolate, exception);
34 if (!message.IsEmpty()) 34 if (!message.IsEmpty())
35 { 35 {
36 error << " at "; 36 error << " at ";
37 error << *v8::String::Utf8Value(isolate, message->GetScriptResourceName()); 37 error << *v8::String::Utf8Value(isolate, message->GetScriptResourceName());
38 error << ":"; 38 error << ":";
39 error << message->GetLineNumber(); 39 auto lineNumber = message->GetLineNumber(isolate->GetCurrentContext());
40 if (lineNumber.IsJust())
41 error << lineNumber.FromJust();
42 else
43 error << "<unknown>";
40 } 44 }
41 return error.str(); 45 return error.str();
42 } 46 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld