Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29810591: #12411 - Create URL redirects for mobile (Closed)

Created:
June 19, 2018, 5:24 p.m. by f.lopez
Modified:
June 22, 2018, 5:23 p.m.
Reviewers:
mathias, Fred
Visibility:
Public.

Description

#12411 - Create URL redirects for mobile

Patch Set 1 #

Total comments: 1

Patch Set 2 : For comment 2 - fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M hiera/roles/web/redirect/eyeo.yaml View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5
f.lopez
June 19, 2018, 5:24 p.m. (2018-06-19 17:24:32 UTC) #1
Fred
https://codereview.adblockplus.org/29810591/diff/29810592/hiera/roles/web/redirect/eyeo.yaml File hiera/roles/web/redirect/eyeo.yaml (right): https://codereview.adblockplus.org/29810591/diff/29810592/hiera/roles/web/redirect/eyeo.yaml#newcode69 hiera/roles/web/redirect/eyeo.yaml:69: adblockplus/android_samsun_install: "https://play.google.com/store/apps/details?id=org.adblockplus.adblockplussbrowser?" Typo: android_samsung_install
June 19, 2018, 10:11 p.m. (2018-06-19 22:11:26 UTC) #2
f.lopez
On 2018/06/19 22:11:26, Fred wrote: > https://codereview.adblockplus.org/29810591/diff/29810592/hiera/roles/web/redirect/eyeo.yaml > File hiera/roles/web/redirect/eyeo.yaml (right): > > https://codereview.adblockplus.org/29810591/diff/29810592/hiera/roles/web/redirect/eyeo.yaml#newcode69 > ...
June 19, 2018, 10:22 p.m. (2018-06-19 22:22:04 UTC) #3
f.lopez
June 19, 2018, 10:23 p.m. (2018-06-19 22:23:13 UTC) #4
mathias
June 20, 2018, 9:39 a.m. (2018-06-20 09:39:51 UTC) #5
LGTM.

Powered by Google App Engine
This is Rietveld