Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29811558: Issue 6754 - Support the "circumvention" type (Closed)

Created:
June 20, 2018, 12:19 p.m. by hub
Modified:
June 20, 2018, 1:31 p.m.
Reviewers:
tlucas
Base URL:
https://hg.adblockplus.org/sitescripts/
Visibility:
Public.

Description

Issue 6754 - Support the "circumvention" type

Patch Set 1 #

Total comments: 1

Patch Set 2 : PEP-8 conformance #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M sitescripts/subscriptions/subscriptionParser.py View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3
hub
June 20, 2018, 12:19 p.m. (2018-06-20 12:19:57 UTC) #1
tlucas
Hey Hub, only a nit - otherwise LGTM. https://codereview.adblockplus.org/29811558/diff/29811559/sitescripts/subscriptions/subscriptionParser.py File sitescripts/subscriptions/subscriptionParser.py (right): https://codereview.adblockplus.org/29811558/diff/29811559/sitescripts/subscriptions/subscriptionParser.py#newcode203 sitescripts/subscriptions/subscriptionParser.py:203: if ...
June 20, 2018, 1:02 p.m. (2018-06-20 13:02:37 UTC) #2
hub
June 20, 2018, 1:19 p.m. (2018-06-20 13:19:35 UTC) #3
updated patch.

will email it.

Powered by Google App Engine
This is Rietveld