Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29812577: Noissue - add a possibility to build only static library libadblockplus for nix (Closed)

Created:
June 21, 2018, 10:20 a.m. by sergei
Modified:
June 21, 2018, 12:49 p.m.
Reviewers:
hub
CC:
anton
Base URL:
https://github.com/adblockplus/libadblockplus@7fd0f9791ae0ba8b6ed725351aeadf98e1fd111e
Visibility:
Public.

Description

In order to reduce fiddling with V8 binaries in our chromium integration and speed up the building we need an option to build only libadblockplus.a Now one can achieve it by specifying `SUB_ACTION` to `make` with the value `libadblockplus`. E.g. `make SUB_ACTION=libadblockplus` Pay attention that since android makefiles are too smart one still has to provide the existing v8_monolith binary although it's not used after evaluation of the generated Makefiles.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M Makefile View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2
sergei
June 21, 2018, 10:26 a.m. (2018-06-21 10:26:39 UTC) #1
hub
June 21, 2018, 12:47 p.m. (2018-06-21 12:47:38 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld