Issue 29812619: Issue 6756 - fix build for android-ia32

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29812619: Issue 6756 - fix build for android-ia32 (Closed)

Created:
June 21, 2018, 2:56 p.m. by sergei

Modified:
June 21, 2018, 3:35 p.m.

Reviewers:
hub

CC:
anton

Base URL:
https://github.com/adblockplus/libadblockplus@2fea9bc22a8ce8ef31a6ddbe9a3dfdfea8290444

Visibility:
Public.

Description

The reason was that android makefiles took into account the environment variable TARGET_ARCH what, resulted in the different and even incorrect configuration. In particular some system headers were used. Now when one compiles for android it seems only headers and libraries from android ndk are used, therefore g++-multilib is not required anymore. I have checked whether some other variables are used by the ndk and did not find such cases. So only TARGET_ARCH is prefixed by ABP_.

Patch Set 1 #

Created: June 21, 2018, 3:03 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -23 lines)			Patch
M	.travis.yml	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	.travis/prepare-prebuilt-v8.sh	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Makefile	View	5 chunks	+9 lines, -9 lines	0 comments	Download
M	README.md	View	3 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages