Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(310)

Issue 29812619: Issue 6756 - fix build for android-ia32 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by sergei
Modified:
1 year, 6 months ago
Reviewers:
hub
CC:
anton
Base URL:
https://github.com/adblockplus/libadblockplus@2fea9bc22a8ce8ef31a6ddbe9a3dfdfea8290444
Visibility:
Public.

Description

The reason was that android makefiles took into account the environment variable TARGET_ARCH what, resulted in the different and even incorrect configuration. In particular some system headers were used. Now when one compiles for android it seems only headers and libraries from android ndk are used, therefore g++-multilib is not required anymore. I have checked whether some other variables are used by the ndk and did not find such cases. So only TARGET_ARCH is prefixed by ABP_.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -23 lines) Patch
M .travis.yml View 2 chunks +3 lines, -4 lines 0 comments Download
M .travis/prepare-prebuilt-v8.sh View 2 chunks +3 lines, -3 lines 0 comments Download
M Makefile View 5 chunks +9 lines, -9 lines 0 comments Download
M README.md View 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 2
sergei
1 year, 6 months ago (2018-06-21 15:03:56 UTC) #1
hub
1 year, 6 months ago (2018-06-21 15:31:18 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5