Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29812646: Issue 6526 - Remove deprecated CreateDefaultPlatform() (Closed)

Created:
June 21, 2018, 9:01 p.m. by hub
Modified:
June 22, 2018, 3:07 a.m.
Reviewers:
sergei
Base URL:
https://hg.adblockplus.org/libadblockplus/
Visibility:
Public.

Description

Issue 6526 - Remove deprecated CreateDefaultPlatform()

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M src/JsEngine.cpp View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 2
hub
June 21, 2018, 9:01 p.m. (2018-06-21 21:01:33 UTC) #1
sergei
June 21, 2018, 10:57 p.m. (2018-06-21 22:57:32 UTC) #2
LGTM, I hope it's mere switching to std::unique_ptr and nothing more.

Powered by Google App Engine
This is Rietveld