Issue 6526 - *ToV8String() return MaybeLocal<> and check Call() return value

src/JsEngine.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 173 matching lines @@
   JsContext context(*this);
   return JsValue(shared_from_this(), context.GetV8Context()->Global());
 }
 
 AdblockPlus::JsValue AdblockPlus::JsEngine::Evaluate(const std::string& source,
     const std::string& filename)
 {
   const JsContext context(*this);
   auto isolate = GetIsolate();
   const v8::TryCatch tryCatch(isolate);
-  auto script = CHECKED_TO_LOCAL(
+  auto script = CHECKED_TO_LOCAL_WITH_TRY_CATCH(
     isolate, CompileScript(isolate, source, filename), tryCatch);
-  auto result = CHECKED_TO_LOCAL(
+  auto result = CHECKED_TO_LOCAL_WITH_TRY_CATCH(
     isolate, script->Run(isolate->GetCurrentContext()), tryCatch);
   return JsValue(shared_from_this(), result);
 }
 
 void AdblockPlus::JsEngine::SetEventCallback(const std::string& eventName,
     const AdblockPlus::JsEngine::EventCallback& callback)
 {
   if (!callback)
   {
     RemoveEventCallback(eventName);
@@ skipping 23 matching lines @@
 }
 
 void AdblockPlus::JsEngine::Gc()
 {
   while (!GetIsolate()->IdleNotificationDeadline(1000));
 }
 
 AdblockPlus::JsValue AdblockPlus::JsEngine::NewValue(const std::string& val)
 {
   const JsContext context(*this);
-  auto maybeValue = Utils::ToV8String(GetIsolate(), val);
-  if (maybeValue.IsEmpty())
-    return JsValue(shared_from_this(), v8::Undefined(GetIsolate()));

[hub, 2018/06/22 00:34:31]

This is where I think we should break APIs to some extent. For now I return
`undefined` if there is an error. 

[sergei, 2018/06/22 06:57:46]

Let's just use CHECKED_TO_LOCAL.

[hub, 2018/06/22 15:50:56]

Done.

-  return JsValue(shared_from_this(), maybeValue.ToLocalChecked());
+  auto isolate = GetIsolate();
+  return JsValue(shared_from_this(),
+    CHECKED_TO_LOCAL(isolate, Utils::ToV8String(isolate, val)));
 }
 
 AdblockPlus::JsValue AdblockPlus::JsEngine::NewValue(int64_t val)
 {
   const JsContext context(*this);
   return JsValue(shared_from_this(), v8::Number::New(GetIsolate(), val));
 }
 
 AdblockPlus::JsValue AdblockPlus::JsEngine::NewValue(bool val)
 {
@@ skipping 88 matching lines @@
     list.push_back(JsValue(shared_from_this(), arguments[i]));
   return list;
 }
 
 void AdblockPlus::JsEngine::SetGlobalProperty(const std::string& name,
                                               const AdblockPlus::JsValue& value)
 {
   auto global = GetGlobalObject();
   global.SetProperty(name, value);
 }