Issue 6526 - Use Maybe<> version of soon to be deprecated API in v8 6.7

src/JsEngine.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 112 matching lines @@
   if (arguments.Length() < 2)
     throw std::runtime_error("setTimeout requires at least 2 parameters");
 
   if (!arguments[0]->IsFunction())
     throw std::runtime_error("First argument to setTimeout must be a function");
 
   auto jsValueArguments = jsEngine->ConvertArguments(arguments);
   auto timerParamsID = jsEngine->StoreJsValues(jsValueArguments);
 
   std::weak_ptr<JsEngine> weakJsEngine = jsEngine;
+
+  int64_t millis = CHECKED_TO_VALUE(
+    arguments[1]->IntegerValue(arguments.GetIsolate()->GetCurrentContext()));
+
   jsEngine->platform.WithTimer(
-    [arguments, weakJsEngine, timerParamsID](ITimer& timer)
+    [millis, weakJsEngine, timerParamsID](ITimer& timer)
     {
       timer.SetTimer(
-        std::chrono::milliseconds(
-          arguments[1]->IntegerValue()), [weakJsEngine, timerParamsID]
+        std::chrono::milliseconds(millis), [weakJsEngine, timerParamsID]
           {
             if (auto jsEngine = weakJsEngine.lock())
               jsEngine->CallTimerTask(timerParamsID);
           });
     });
 }
 
 void JsEngine::CallTimerTask(const JsWeakValuesID& timerParamsID)
 {
   auto timerParams = TakeJsValues(timerParamsID);
@@ skipping 108 matching lines @@
 AdblockPlus::JsValue AdblockPlus::JsEngine::NewObject()
 {
   const JsContext context(*this);
   return JsValue(shared_from_this(), v8::Object::New(GetIsolate()));
 }
 
 AdblockPlus::JsValue AdblockPlus::JsEngine::NewCallback(
     const v8::FunctionCallback& callback)
 {
   const JsContext context(*this);
-
+  auto isolate = GetIsolate();
   // Note: we are leaking this weak pointer, no obvious way to destroy it when
   // it's no longer used
   std::weak_ptr<JsEngine>* data =
       new std::weak_ptr<JsEngine>(shared_from_this());
-  v8::Local<v8::FunctionTemplate> templ = v8::FunctionTemplate::New(GetIsolate(), callback,
-      v8::External::New(GetIsolate(), data));
-  return JsValue(shared_from_this(), templ->GetFunction());
+  v8::Local<v8::FunctionTemplate> templ = v8::FunctionTemplate::New(isolate, callback,
+      v8::External::New(isolate, data));
+  return JsValue(shared_from_this(),
+      CHECKED_TO_LOCAL_NOTHROW(isolate, templ->GetFunction(isolate->GetCurrentContext())));
 }
 
 AdblockPlus::JsEnginePtr AdblockPlus::JsEngine::FromArguments(const v8::FunctionCallbackInfo<v8::Value>& arguments)
 {
   const v8::Local<const v8::External> external =
       v8::Local<const v8::External>::Cast(arguments.Data());
   std::weak_ptr<JsEngine>* data =
       static_cast<std::weak_ptr<JsEngine>*>(external->Value());
   JsEnginePtr result = data->lock();
   if (!result)
@@ skipping 56 matching lines @@
     list.push_back(JsValue(shared_from_this(), arguments[i]));
   return list;
 }
 
 void AdblockPlus::JsEngine::SetGlobalProperty(const std::string& name,
                                               const AdblockPlus::JsValue& value)
 {
   auto global = GetGlobalObject();
   global.SetProperty(name, value);
 }