Issue 6526 - Use Maybe<> version of soon to be deprecated API in v8 6.7

test/JsValue.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 193 matching lines @@
   params.push_back(GetJsEngine().NewValue("xyz"));
   ASSERT_EQ("2/5/xyz", value.Call(params, thisPtr).AsString());
 }
 
 TEST_F(JsValueTest, JsValueCallSingleArg)
 {
   auto func = GetJsEngine().Evaluate("(function(arg) {return arg * 2;})");
   EXPECT_EQ(10, func.Call(GetJsEngine().NewValue(5)).AsInt());
 }
 
-TEST_F(JsValueTest, ThrowingCoversion)
+TEST_F(JsValueTest, ThrowingConversion)

[sergei, 2018/08/07 13:14:51]

It's unrelated but OK.

 {
   const std::string source("\
     function Foo() {\
       this.toString = function() {throw 'test1';};\
       this.valueOf = function() {throw 'test2';};\
     };\
     new Foo()");
   auto value = GetJsEngine().Evaluate(source);
   ASSERT_EQ("", value.AsString());
   ASSERT_EQ(0, value.AsInt());
 }