Issue 6526 - Use Maybe<> version of soon to be deprecated API in v8 6.7

test/JsValue.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include "BaseJsTest.h"
 
+#include "../src/Utils.h"
+
 namespace
 {
   class JsValueTest : public BaseJsTest
   {
   };
+}
+
+TEST_F(JsValueTest, Checked)
+{
+  auto value = v8::MaybeLocal<bool>();
+  ASSERT_ANY_THROW(CHECKED_TO_LOCAL(GetJsEngine().GetIsolate(),
+                                    std::move(value)));
 }
 
 TEST_F(JsValueTest, UndefinedValue)
 {
   auto value = GetJsEngine().Evaluate("undefined");
   ASSERT_TRUE(value.IsUndefined());
   ASSERT_FALSE(value.IsNull());
   ASSERT_FALSE(value.IsString());
   ASSERT_FALSE(value.IsBool());
   ASSERT_FALSE(value.IsNumber());
@@ skipping 119 matching lines @@
   ASSERT_TRUE(value.AsBool());
   ASSERT_ANY_THROW(value.AsList());
   ASSERT_EQ(2, value.GetProperty("x").AsInt());
   value.SetProperty("x", 12);
   ASSERT_EQ(12, value.GetProperty("x").AsInt());
   value.SetProperty("x", GetJsEngine().NewValue(15));
   ASSERT_EQ(15, value.GetProperty("x").AsInt());
   ASSERT_EQ("Foo", value.GetClass());
   ASSERT_EQ(3u, value.GetOwnPropertyNames().size());
   ASSERT_ANY_THROW(value.Call());
+  ASSERT_TRUE(value.GetProperty("bar").IsUndefined());
 }
 
 TEST_F(JsValueTest, ArrayValue)
 {
   auto value = GetJsEngine().Evaluate("[5,8,12]");
   ASSERT_FALSE(value.IsUndefined());
   ASSERT_FALSE(value.IsNull());
   ASSERT_FALSE(value.IsString());
   ASSERT_FALSE(value.IsBool());
   ASSERT_FALSE(value.IsNumber());
@@ skipping 30 matching lines @@
   params.push_back(GetJsEngine().NewValue("xyz"));
   ASSERT_EQ("2/5/xyz", value.Call(params, thisPtr).AsString());
 }
 
 TEST_F(JsValueTest, JsValueCallSingleArg)
 {
   auto func = GetJsEngine().Evaluate("(function(arg) {return arg * 2;})");
   EXPECT_EQ(10, func.Call(GetJsEngine().NewValue(5)).AsInt());
 }
 
 TEST_F(JsValueTest, ThrowingConversion)

[sergei, 2018/08/07 13:14:51]

It's unrelated but OK.

 {
   const std::string source("\
     function Foo() {\
       this.toString = function() {throw 'test1';};\
       this.valueOf = function() {throw 'test2';};\
     };\
     new Foo()");
   auto value = GetJsEngine().Evaluate(source);
   ASSERT_EQ("", value.AsString());
-  ASSERT_EQ(0, value.AsInt());
-}
+  ASSERT_ANY_THROW(value.AsInt());
+}