Issue 6526 - Use Maybe<> version of soon to be deprecated API in v8 6.7

src/JsValue.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 120 matching lines @@
 {
   const JsContext context(*jsEngine);
   return Utils::StringBufferFromV8String(jsEngine->GetIsolate(), UnwrapValue());
 }
 
 int64_t AdblockPlus::JsValue::AsInt() const
 {
   const JsContext context(*jsEngine);
   auto currentContext = jsEngine->GetIsolate()->GetCurrentContext();
   auto value = UnwrapValue()->IntegerValue(currentContext);
-  return value.IsJust() ? value.FromJust() : 0;

[sergei, 2018/08/07 13:14:52]

What about using of CheckedToValue here?
Returning of a value can be misleading and a particular value like zero can make
no sense in a domain. It can be especially sensitive in AsBool.

[hub, 2018/08/07 14:36:48]

I wanted to avoid throwing an exception. But it seems to be the only way.

+  return CHECKED_TO_VALUE(std::move(value));

[sergei, 2018/08/07 16:47:35]

I find the usage of std::move good here too, for the sake of readability.

 }
 
 bool AdblockPlus::JsValue::AsBool() const
 {
   const JsContext context(*jsEngine);
   auto currentContext = jsEngine->GetIsolate()->GetCurrentContext();
   auto value = UnwrapValue()->BooleanValue(currentContext);
-  return value.IsJust() ? value.FromJust() : false;
+  return CHECKED_TO_VALUE(std::move(value));
 }
 
 AdblockPlus::JsValueList AdblockPlus::JsValue::AsList() const
 {
   if (!IsArray())
     throw std::runtime_error("Cannot convert a non-array to list");
 
   const JsContext context(*jsEngine);
   auto isolate = jsEngine->GetIsolate();
   auto currentContext = isolate->GetCurrentContext();
@@ skipping 147 matching lines @@
   auto isolate = jsEngine->GetIsolate();
 
   const v8::TryCatch tryCatch(isolate);
   v8::Local<v8::Function> func = v8::Local<v8::Function>::Cast(UnwrapValue());
   auto result = CHECKED_TO_LOCAL_WITH_TRY_CATCH(
     isolate, func->Call(isolate->GetCurrentContext(),
       thisObj, args.size(), args.size() ? &args[0] : nullptr), tryCatch);
 
   return JsValue(jsEngine, result);
 }