Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(37)

Issue 29816555: Issue 6727 - Avoid getter for multi-domain cases

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 weeks, 1 day ago by Manish Jethani
Modified:
3 weeks, 1 day ago
Reviewers:
sergei
CC:
kzar
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Issue 6727 - Avoid getter for multi-domain cases

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M lib/filterClasses.js View 2 chunks +9 lines, -11 lines 0 comments Download

Messages

Total messages: 2
Manish Jethani
3 weeks, 1 day ago (2018-06-26 17:02:19 UTC) #1
Manish Jethani
3 weeks, 1 day ago (2018-06-26 17:04:32 UTC) #2
Patch Set 1

Sorry, this should have been part of the previous change. There's no need to run
through the getter each time for multi-domain cases. There's also no need to
store a null value in every object (we can go through the getter for no-domain
cases).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5