Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(550)

Issue 29816555: Issue 6727 - Avoid getter for multi-domain cases (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 3 weeks ago by Manish Jethani
Modified:
1 month, 3 weeks ago
Reviewers:
sergei
CC:
kzar
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Issue 6727 - Avoid getter for multi-domain cases

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M lib/filterClasses.js View 2 chunks +9 lines, -11 lines 0 comments Download

Messages

Total messages: 3
Manish Jethani
2 months, 3 weeks ago (2018-06-26 17:02:19 UTC) #1
Manish Jethani
Patch Set 1 Sorry, this should have been part of the previous change. There's no ...
2 months, 3 weeks ago (2018-06-26 17:04:32 UTC) #2
Manish Jethani
1 month, 3 weeks ago (2018-07-30 16:57:58 UTC) #3
Withdrawing this patch now, since I'm inclined towards removing this
optimization entirely in favor of #6815:
https://codereview.adblockplus.org/29841558/#ps29843051
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5