README.md - Issue 29817566: Noissue - Use clang++ and libc++ on Linux

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: README.md

Issue 29817566: Noissue - Use clang++ and libc++ on Linux (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/

Patch Set: Added note about libc++ Created June 28, 2018, 2:11 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 libadblockplus	1 libadblockplus

2 ==============	2 ==============

3	3

4 A C++ library offering the core functionality of Adblock Plus.	4 A C++ library offering the core functionality of Adblock Plus.

5	5

6 Getting/updating the dependencies	6 Getting/updating the dependencies

7 ---------------------------------	7 ---------------------------------

8	8

9 libadblockplus has dependencies that aren't part of this repository. They are	9 libadblockplus has dependencies that aren't part of this repository. They are

10 retrieved and updated during the build process, but you can also manually update	10 retrieved and updated during the build process, but you can also manually update

(...skipping 12 matching lines...) Expand all Loading...
23	23

24 ### Supported target platforms and prerequisites	24 ### Supported target platforms and prerequisites

25	25

26 You need a C++14 compatible compiler to build libadblockplus. Below there is	26 You need a C++14 compatible compiler to build libadblockplus. Below there is

27 the list of tested tools.	27 the list of tested tools.

28	28

29 Win32:	29 Win32:

30 * At least v141 Visual C++ toolset (available in Microsoft Visual Studio 2017).	30 * At least v141 Visual C++ toolset (available in Microsoft Visual Studio 2017).

31	31

32 Linux:	32 Linux:

33 * g++ 7.3	33 * clang 5.5
	anton 2018/07/02 10:12:38 in travis config it's clang 4.0 required, but in R in travis config it's clang 4.0 required, but in README it's 5.5. Which one? Also in travis g++ is still required (`g++-7`), but here it's just deleted from requirements. hub 2018/07/04 07:50:49 I have changed it to 5.0. And remove the explicit Show quoted text On 2018/07/02 10:12:38, anton wrote: > in travis config it's clang 4.0 required, but in README it's 5.5. Which one? > Also in travis g++ is still required (`g++-7`), but here it's just deleted from > requirements. I have changed it to 5.0. And remove the explicit dependencies for clang and gcc in the travis.yml. 5.0 is what is provided if you specify clang as the C++ compiler. I have tested it on TravisCI.
	34 We use libc++ instead of the libstdc++ that gcc uses.

34	35

35 Mac:	36 Mac:

36 * Apple LLVM 9.1.0 for OS X/macOS (Xcode should be installed and its developer t ools should be "selected").	37 * Apple LLVM 9.0.0 for OS X/macOS (Xcode should be installed and its

	38 developer tools should be "selected").

37	39

38 Android:	40 Android:

39 * The host system should be Linux or OS X	41 * The host system should be Linux or OS X

40 * android-ndk-r16b, here are the links for downloading	42 * android-ndk-r16b, here are the links for downloading

41 [OS X](https://dl.google.com/android/repository/android-ndk-r16b-darwin-x86_64 .zip),	43 [OS X](https://dl.google.com/android/repository/android-ndk-r16b-darwin-x86_64 .zip),

42 [Linux 64](https://dl.google.com/android/repository/android-ndk-r16b-linux-x86 _64.zip).	44 [Linux 64](https://dl.google.com/android/repository/android-ndk-r16b-linux-x86 _64.zip).

43 * g++ multilib	45 * g++ multilib

44	46

45 If you have a compilation issue with another compiler please [create an issue](h ttps://issues.adblockplus.org/).	47 If you have a compilation issue with another compiler please [create an issue](h ttps://issues.adblockplus.org/).

46	48

(...skipping 251 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
298 Linting	300 Linting

299 -------	301 -------

300	302

301 You can lint the code using [ESLint](http://eslint.org).	303 You can lint the code using [ESLint](http://eslint.org).

302	304

303 npm run eslint	305 npm run eslint

304	306

305 In order to set up ESLint and	307 In order to set up ESLint and

306 [configuration eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/t ip/eslint-config-eyeo) you need [Node.js 7 or higher](https://nodejs.org/) and o nce it is installed please run `npm install` in the repository directory.	308 [configuration eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/t ip/eslint-config-eyeo) you need [Node.js 7 or higher](https://nodejs.org/) and o nce it is installed please run `npm install` in the repository directory.

307	309

OLD	NEW

« no previous file with comments | « Makefile ('k') | common.gypi » ('j') | no next file with comments »