README.md - Issue 29817566: Noissue - Use clang++ and libc++ on Linux

Delta Between Two Patch Sets: README.md

Issue 29817566: Noissue - Use clang++ and libc++ on Linux (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/

Left Patch Set: Added note about libc++ Created June 28, 2018, 2:11 p.m.

Right Patch Set: Fix Travis dependencies. Created July 4, 2018, 7:48 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 libadblockplus	1 libadblockplus

2 ==============	2 ==============

3	3

4 A C++ library offering the core functionality of Adblock Plus.	4 A C++ library offering the core functionality of Adblock Plus.

5	5

6 Getting/updating the dependencies	6 Getting/updating the dependencies

7 ---------------------------------	7 ---------------------------------

8	8

9 libadblockplus has dependencies that aren't part of this repository. They are	9 libadblockplus has dependencies that aren't part of this repository. They are

10 retrieved and updated during the build process, but you can also manually update	10 retrieved and updated during the build process, but you can also manually update

(...skipping 12 matching lines...) Expand all Loading...
23	23

24 ### Supported target platforms and prerequisites	24 ### Supported target platforms and prerequisites

25	25

26 You need a C++14 compatible compiler to build libadblockplus. Below there is	26 You need a C++14 compatible compiler to build libadblockplus. Below there is

27 the list of tested tools.	27 the list of tested tools.

28	28

29 Win32:	29 Win32:

30 * At least v141 Visual C++ toolset (available in Microsoft Visual Studio 2017).	30 * At least v141 Visual C++ toolset (available in Microsoft Visual Studio 2017).

31	31

32 Linux:	32 Linux:

33 * clang 5.5	33 * clang 5.0
anton 2018/07/02 10:12:38 in travis config it's clang 4.0 required, but in R in travis config it's clang 4.0 required, but in README it's 5.5. Which one? Also in travis g++ is still required (`g++-7`), but here it's just deleted from requirements. hub 2018/07/04 07:50:49 I have changed it to 5.0. And remove the explicit Show quoted text On 2018/07/02 10:12:38, anton wrote: > in travis config it's clang 4.0 required, but in README it's 5.5. Which one? > Also in travis g++ is still required (`g++-7`), but here it's just deleted from > requirements. I have changed it to 5.0. And remove the explicit dependencies for clang and gcc in the travis.yml. 5.0 is what is provided if you specify clang as the C++ compiler. I have tested it on TravisCI.
34 We use libc++ instead of the libstdc++ that gcc uses.	34 We use libc++ instead of the libstdc++ that gcc uses, since by default v8 build

	35 with libc++.

35	36

36 Mac:	37 Mac:

37 * Apple LLVM 9.0.0 for OS X/macOS (Xcode should be installed and its	38 * Apple LLVM 9.0.0 for OS X/macOS (Xcode should be installed and its

38 developer tools should be "selected").	39 developer tools should be "selected").

39	40

40 Android:	41 Android:

41 * The host system should be Linux or OS X	42 * The host system should be Linux or OS X

42 * android-ndk-r16b, here are the links for downloading	43 * android-ndk-r16b, here are the links for downloading

43 [OS X](https://dl.google.com/android/repository/android-ndk-r16b-darwin-x86_64 .zip),	44 [OS X](https://dl.google.com/android/repository/android-ndk-r16b-darwin-x86_64 .zip),

44 [Linux 64](https://dl.google.com/android/repository/android-ndk-r16b-linux-x86 _64.zip).	45 [Linux 64](https://dl.google.com/android/repository/android-ndk-r16b-linux-x86 _64.zip).

(...skipping 255 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
300 Linting	301 Linting

301 -------	302 -------

302	303

303 You can lint the code using [ESLint](http://eslint.org).	304 You can lint the code using [ESLint](http://eslint.org).

304	305

305 npm run eslint	306 npm run eslint

306	307

307 In order to set up ESLint and	308 In order to set up ESLint and

308 [configuration eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/t ip/eslint-config-eyeo) you need [Node.js 7 or higher](https://nodejs.org/) and o nce it is installed please run `npm install` in the repository directory.	309 [configuration eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/t ip/eslint-config-eyeo) you need [Node.js 7 or higher](https://nodejs.org/) and o nce it is installed please run `npm install` in the repository directory.

309	310

LEFT	RIGHT