Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(25)

Issue 29819555: Fix libadblockplus-android tests

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 3 days ago by René Jeschke
Modified:
3 days, 2 hours ago
Reviewers:
anton
Visibility:
Public.

Description

Fix libadblockplus-android tests

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+286 lines, -501 lines) Patch
M adblock-android-tests/build.gradle View 1 chunk +0 lines, -1 line 0 comments Download
D adblock-android-tests/src/org/adblockplus/libadblockplus/LazyWebRequest.java View 1 chunk +0 lines, -32 lines 0 comments Download
M adblock-android-tests/src/org/adblockplus/libadblockplus/MockFilterChangeCallback.java View 2 chunks +18 lines, -3 lines 0 comments Download
M adblock-android-tests/src/org/adblockplus/libadblockplus/NoOpUpdaterCallback.java View 1 chunk +8 lines, -0 lines 0 comments Download
M adblock-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestResourceWrapperTest.java View 8 chunks +23 lines, -48 lines 0 comments Download
M adblock-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestTest.java View 6 chunks +38 lines, -23 lines 0 comments Download
M adblock-android-tests/src/org/adblockplus/libadblockplus/tests/AppInfoJsObjectTest.java View 4 chunks +7 lines, -9 lines 0 comments Download
D adblock-android-tests/src/org/adblockplus/libadblockplus/tests/BaseFilterEngineTest.java View 1 chunk +0 lines, -56 lines 0 comments Download
D adblock-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsEngineTest.java View 1 chunk +0 lines, -32 lines 0 comments Download
D adblock-android-tests/src/org/adblockplus/libadblockplus/tests/BasePlatformTest.java View 1 chunk +0 lines, -69 lines 0 comments Download
M adblock-android-tests/src/org/adblockplus/libadblockplus/tests/ConsoleJsObjectTest.java View 2 chunks +5 lines, -2 lines 0 comments Download
M adblock-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineTest.java View 5 chunks +62 lines, -12 lines 3 comments Download
M adblock-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineUpdaterTest.java View 2 chunks +17 lines, -5 lines 0 comments Download
M adblock-android-tests/src/org/adblockplus/libadblockplus/tests/GlobalJsObjectTest.java View 1 chunk +1 line, -0 lines 0 comments Download
M adblock-android-tests/src/org/adblockplus/libadblockplus/tests/IsAllowedConnectionCallbackTest.java View 7 chunks +30 lines, -42 lines 0 comments Download
M adblock-android-tests/src/org/adblockplus/libadblockplus/tests/JsEngineTest.java View 1 chunk +1 line, -0 lines 0 comments Download
M adblock-android-tests/src/org/adblockplus/libadblockplus/tests/JsTest.java View 1 chunk +1 line, -0 lines 0 comments Download
M adblock-android-tests/src/org/adblockplus/libadblockplus/tests/MockWebRequestTest.java View 4 chunks +30 lines, -74 lines 0 comments Download
M adblock-android-tests/src/org/adblockplus/libadblockplus/tests/NotificationTest.java View 6 chunks +10 lines, -13 lines 0 comments Download
M adblock-android-tests/src/org/adblockplus/libadblockplus/tests/UpdateCheckTest.java View 11 chunks +35 lines, -38 lines 0 comments Download
D adblock-android-tests/src/org/adblockplus/libadblockplus/tests/UpdaterTest.java View 1 chunk +0 lines, -42 lines 0 comments Download

Messages

Total messages: 5
René Jeschke
1 week ago (2018-07-11 13:37:04 UTC) #1
anton
On 2018/07/11 13:37:04, René Jeschke wrote: What do you think about using mockito or powermock?
1 week ago (2018-07-11 13:57:31 UTC) #2
anton
https://codereview.adblockplus.org/29819555/diff/29819556/adblock-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineTest.java File adblock-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineTest.java (right): https://codereview.adblockplus.org/29819555/diff/29819556/adblock-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineTest.java#newcode56 adblock-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineTest.java:56: int prev = filterEngine.getListedFilters().size(); extra not required space
1 week ago (2018-07-11 13:58:31 UTC) #3
anton
On 2018/07/11 13:58:31, anton wrote: > https://codereview.adblockplus.org/29819555/diff/29819556/adblock-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineTest.java > File > adblock-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineTest.java > (right): > > ...
1 week ago (2018-07-11 14:02:44 UTC) #4
anton
3 days, 2 hours ago (2018-07-16 06:58:53 UTC) #5
https://codereview.adblockplus.org/29819555/diff/29819556/adblock-android-tes...
File
adblock-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineTest.java
(right):

https://codereview.adblockplus.org/29819555/diff/29819556/adblock-android-tes...
adblock-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineTest.java:32:
public class FilterEngineTest extends BaseFilterEngineTest
i was unable to apply diff patch so just looking the sources.
Since `BaseFilterEngineTest` is deleted
(https://codereview.adblockplus.org/29819555/patch/29819556/29819558) how can
this file be compiled?

What about deleted `BasePlatformTest`
https://codereview.adblockplus.org/29819555/diff/29819556/adblock-android-tes...
?

https://codereview.adblockplus.org/29819555/diff/29819556/adblock-android-tes...
adblock-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineTest.java:377:

i still can see first run flag test in c++ source:
https://github.com/adblockplus/libadblockplus/blob/master/test/FilterEngine.c...

but here it's just deleted.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5