sitescripts/subscriptions/test/test_updateMalwareDomainsList.py - Issue 29821558: Issue #6707 - Make the generated malware domain filter list encode domains as Punycode

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: sitescripts/subscriptions/test/test_updateMalwareDomainsList.py

Issue 29821558: Issue #6707 - Make the generated malware domain filter list encode domains as Punycode (Closed)

Left Patch Set: Updated encoding format Created July 6, 2018, 11:51 a.m.

Right Patch Set: Removed uncessary codecs call from updateMalwareDomains.py Created July 9, 2018, 1:08 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
(Both sides are equal)
1 # This file is part of the Adblock Plus web scripts,	1 # This file is part of the Adblock Plus web scripts,

2 # Copyright (C) 2006-present eyeo GmbH	2 # Copyright (C) 2006-present eyeo GmbH

3 #	3 #

4 # Adblock Plus is free software: you can redistribute it and/or modify	4 # Adblock Plus is free software: you can redistribute it and/or modify

5 # it under the terms of the GNU General Public License version 3 as	5 # it under the terms of the GNU General Public License version 3 as

6 # published by the Free Software Foundation.	6 # published by the Free Software Foundation.

7 #	7 #

8 # Adblock Plus is distributed in the hope that it will be useful,	8 # Adblock Plus is distributed in the hope that it will be useful,

9 # but WITHOUT ANY WARRANTY; without even the implied warranty of	9 # but WITHOUT ANY WARRANTY; without even the implied warranty of

10 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the	10 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

(...skipping 82 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
93 def test_ugly(md_repo, config):	93 def test_ugly(md_repo, config):

94 config.set(CONF_SECTION, 'malwaredomains_mirrors', 'bad\nugly')	94 config.set(CONF_SECTION, 'malwaredomains_mirrors', 'bad\nugly')

95 try:	95 try:

96 main()	96 main()

97 except SystemExit as exc:	97 except SystemExit as exc:

98 err_lines = str(exc).splitlines()	98 err_lines = str(exc).splitlines()

99 assert len(err_lines) == 4	99 assert len(err_lines) == 4

100 assert 'Failed to fetch bad/files/justdomains.zip' in err_lines[2]	100 assert 'Failed to fetch bad/files/justdomains.zip' in err_lines[2]

101 assert 'Failed to fetch ugly/files/justdomains.zip' in err_lines[3]	101 assert 'Failed to fetch ugly/files/justdomains.zip' in err_lines[3]

102 assert 'Ugly' in err_lines[3]	102 assert 'Ugly' in err_lines[3]

LEFT	RIGHT