sitescripts/subscriptions/bin/updateMalwareDomainsList.py - Issue 29821558: Issue #6707 - Make the generated malware domain filter list encode domains as Punycode

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: sitescripts/subscriptions/bin/updateMalwareDomainsList.py

Issue 29821558: Issue #6707 - Make the generated malware domain filter list encode domains as Punycode (Closed)

Patch Set: Updated encoding format Created July 6, 2018, 11:51 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: sitescripts/subscriptions/bin/updateMalwareDomainsList.py

diff --git a/sitescripts/subscriptions/bin/updateMalwareDomainsList.py b/sitescripts/subscriptions/bin/updateMalwareDomainsList.py

index a2cfb5ff8d46bfe4534dc79f0f03f47e31257519..8f573dc8f86161b38f63f41d671a945530f9567a 100644

--- a/sitescripts/subscriptions/bin/updateMalwareDomainsList.py

+++ b/sitescripts/subscriptions/bin/updateMalwareDomainsList.py

@@ -60,7 +60,7 @@ def main():

subprocess.check_call(['hg', '-q', 'up', '-R', tempdir, '-r', 'default'])

path = os.path.join(tempdir, 'malwaredomains_full.txt')

- file = codecs.open(path, 'wb', encoding='utf-8')

+ file = codecs.open(path, 'wb')

Sebastian Noack 2018/07/06 18:23:25 codecs.open() without specifying an encoding is eq

Sebastian Noack 2018/07/09 11:59:29 That is what I'm suggesting.

Tudor Avram 2018/07/09 13:35:42 Done.

print >>file, FILTERLIST_HEADER

@@ -80,7 +80,7 @@ def main():

if not domain:

continue

- print >>file, '||%s^' % domain.decode('idna')

+ print >>file, '||%s^' % domain

file.close()

if subprocess.check_output(['hg', 'stat', '-R', tempdir]) != '':

« no previous file with comments | « .gitignore ('k') | sitescripts/subscriptions/test/test_updateMalwareDomainsList.py » ('j') | no next file with comments »