Noissue - add unit-test to check that renameFile works as expected by FilterStorage.js

test/FileSystemJsObject.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include <sstream>
 #include "BaseJsTest.h"
 #include "../src/Thread.h"
 
 using namespace AdblockPlus;
 
+extern std::string jsSources[];
+
 namespace
 {
   class MockFileSystem : public AdblockPlus::IFileSystem
   {
   public:
     bool success;
     IOBuffer contentToRead;
     std::string lastWrittenFile;
     IOBuffer lastWrittenContent;
     std::string movedFrom;
@@ skipping 357 matching lines @@
     {
       throw new Error("my-error");
     }
     _triggerEvent("onLine", line);
   },
   () => _triggerEvent("onDone"),
   (error) => _triggerEvent("onDone", error));
 )js");
   EXPECT_EQ(2u, readLines.size());
   EXPECT_EQ("Error: my-error at undefined:8", error);
-}
+}
+
+TEST_F(FileSystemJsObjectTest, MoveNonExistingFile)
+{
+  mockFileSystem->success = false;
+  auto& jsEngine = GetJsEngine();
+  const std::vector<std::string> jsFiles = {"compat.js", "io.js"};
+  for (int i = 0; !jsSources[i].empty(); i += 2)
+  {
+    if (jsFiles.end() != std::find(jsFiles.begin(), jsFiles.end(), jsSources[i]))
+    {
+      jsEngine.Evaluate(jsSources[i + 1], jsSources[i]);
+    }
+  }
+  jsEngine.Evaluate(R"js(
+    let hasError = false;
+    let isNextHandlerCalled = false;
+    require("io").IO.renameFile("foo", "bar")
+      .catch((e) => {hasError = e})
+      .then(() => isNextHandlerCalled = true);
+  )js");
+  EXPECT_EQ("Unable to move foo to bar", jsEngine.Evaluate("hasError").AsString());
+  EXPECT_TRUE(jsEngine.Evaluate("isNextHandlerCalled").AsBool());
+}