Issue 6291 - add ManifoldJS packaging for Edge

packagerEdge.py

 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 import os
 import shutil
 from StringIO import StringIO
 import subprocess
 import tempfile
 from xml.etree import ElementTree
@@ skipping 60 matching lines @@
             ('Square150x150Logo', assets[150]),
             ('Square44x44Logo', assets[44]),
         ]),
     ]
 
     tree = ElementTree.parse(manifest_path)
     root = tree.getroot()
 
     for xpath, text, attributes in overrides:
         element = root.find(xpath, namespaces)
-        element.text = text

[Sebastian Noack, 2018/08/08 22:27:32]

We should check if text is not None. It may not be a problem in practice at the
moment if all elements we get None for here don't have a text. But I think we
should not attempt to clear the text if we merely care about the attributes.

[tlucas, 2018/08/09 07:09:24]

Done.

+        if text:
+            element.text = text
         for attr, value in attributes:
                 element.set(attr, value)
 
     tree.write(manifest_path, encoding='utf-8', xml_declaration=True)
 
 
 def createBuild(baseDir, type='edge', outFile=None,  # noqa: preserve API.
                 buildNum=None, releaseBuild=False, keyFile=None,
                 devenv=False):
 
@@ skipping 84 matching lines @@
         cmd = ['npm', 'run', '--silent', 'package-edge']
 
         subprocess.check_call(cmd, env=cmd_env, cwd=os.path.dirname(__file__))
 
         package = os.path.join(manifold_folder, 'package',
                                'edgeExtension.appx')
 
         shutil.copyfile(package, outfile)
     finally:
         shutil.rmtree(tmp_dir, ignore_errors=True)