Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(202)

Issue 29825579: Issue #6681 - Add linting for .gitlab-ci.yml (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 4 months ago by tlucas
Modified:
1 year, 4 months ago
CC:
mathias
Base URL:
https://hg.adblockplus.org/buildtools/file/9a56d76cd951
Visibility:
Public.

Description

Issue #6681 - Add linting for .gitlab-ci.yml

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -8 lines) Patch
M README.md View 1 chunk +3 lines, -0 lines 0 comments Download
M build.py View 7 chunks +36 lines, -8 lines 2 comments Download

Messages

Total messages: 8
tlucas
Patch Set 1: * Add linting for .gitlab-ci.yml files
1 year, 4 months ago (2018-07-09 11:42:47 UTC) #1
Vasily Kuznetsov
Hi Tristan, The change makes sense to me generally although it seems like quite some ...
1 year, 4 months ago (2018-07-09 17:59:48 UTC) #2
tlucas
https://codereview.adblockplus.org/29825579/diff/29825580/build.py File build.py (right): https://codereview.adblockplus.org/29825579/diff/29825580/build.py#newcode401 build.py:401: print urllib2.urlopen(request).read() On 2018/07/09 17:59:48, Vasily Kuznetsov wrote: > ...
1 year, 4 months ago (2018-07-10 09:41:35 UTC) #3
Vasily Kuznetsov
On 2018/07/10 09:41:35, tlucas wrote: > https://codereview.adblockplus.org/29825579/diff/29825580/build.py > File build.py (right): > > https://codereview.adblockplus.org/29825579/diff/29825580/build.py#newcode401 > ...
1 year, 4 months ago (2018-07-10 14:30:36 UTC) #4
tlucas
On 2018/07/10 14:30:36, Vasily Kuznetsov wrote: > On 2018/07/10 09:41:35, tlucas wrote: > > https://codereview.adblockplus.org/29825579/diff/29825580/build.py ...
1 year, 4 months ago (2018-07-10 15:07:27 UTC) #5
Vasily Kuznetsov
On 2018/07/10 15:07:27, tlucas wrote: > On 2018/07/10 14:30:36, Vasily Kuznetsov wrote: > > On ...
1 year, 4 months ago (2018-07-10 15:44:04 UTC) #6
Vasily Kuznetsov
On 2018/07/10 15:44:04, Vasily Kuznetsov wrote: > On 2018/07/10 15:07:27, tlucas wrote: > > On ...
1 year, 4 months ago (2018-07-10 15:51:11 UTC) #7
Sebastian Noack
1 year, 4 months ago (2018-07-10 15:55:42 UTC) #8
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5