Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: README.md

Issue 29825642: Noissue - add 7z requirement into README.md (Closed) Base URL: https://github.com/adblockplus/libadblockplus@d361cdf75c6c5af2aaa9b484092ded6c0a1dc441
Patch Set: address comments Created July 9, 2018, 3:20 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 libadblockplus 1 libadblockplus
2 ============== 2 ==============
3 3
4 A C++ library offering the core functionality of Adblock Plus. 4 A C++ library offering the core functionality of Adblock Plus.
5 5
6 Getting/updating the dependencies 6 Getting/updating the dependencies
7 --------------------------------- 7 ---------------------------------
8 8
9 libadblockplus has dependencies that aren't part of this repository. They are 9 libadblockplus has dependencies that aren't part of this repository. They are
10 retrieved and updated during the build process, but you can also manually update 10 retrieved and updated during the build process, but you can also manually update
11 them by running the following: 11 them by running the following:
12 12
13 ./ensure_dependencies.py 13 ./ensure_dependencies.py
14 14
15 Additionally one should provide V8 headers in order to build libadblockplus 15 Additionally one should provide V8 headers in order to build libadblockplus
16 library and V8 prebuilt libraries in order to link a binary (executable, shared 16 library and V8 prebuilt libraries in order to link a binary (executable, shared
17 object/DLL), even libadblockplus tests. The last time is was tested against V8 17 object/DLL), even libadblockplus tests. The last time is was tested against V8
18 6.7. 18 6.7.
19 For more details see below. 19 For more details see below.
20 20
21 Building 21 Building
22 -------- 22 --------
23 23
24 ### Supported target platforms and prerequisites 24 ### Supported target platforms and prerequisites
25 25
26 You need a C++14 compatible compiler to build libadblockplus. Below there is 26 General:
27 * You need a C++14 compatible compiler to build libadblockplus. Below there is
27 the list of tested tools. 28 the list of tested tools.
28 29
30 * 7z
31 We use 7z for prebuilt V8. In order to install it on a debian-based system
32 one can use `p7zip-full` package and `p7zip-plugins` on rpm-based.
hub 2018/07/13 14:39:36 I'd write "one can use `p7zip-full` package, or
sergei 2018/08/20 10:07:34 Done.
33
29 Win32: 34 Win32:
30 * At least v141 Visual C++ toolset (available in Microsoft Visual Studio 2017). 35 * At least v141 Visual C++ toolset (available in Microsoft Visual Studio 2017).
31 36
32 Linux: 37 Linux:
33 * clang 5.0 38 * clang 5.0
34 We use libc++ instead of the libstdc++ that gcc uses, since by default v8 build 39 We use libc++ instead of the libstdc++ that gcc uses, since by default v8 build
35 with libc++. 40 with libc++.
36 41
37 Mac: 42 Mac:
38 * Apple LLVM 9.0.0 for OS X/macOS (Xcode should be installed and its 43 * Apple LLVM 9.0.0 for OS X/macOS (Xcode should be installed and its
(...skipping 262 matching lines...) Expand 10 before | Expand all | Expand 10 after
301 Linting 306 Linting
302 ------- 307 -------
303 308
304 You can lint the code using [ESLint](http://eslint.org). 309 You can lint the code using [ESLint](http://eslint.org).
305 310
306 npm run eslint 311 npm run eslint
307 312
308 In order to set up ESLint and 313 In order to set up ESLint and
309 [configuration eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/t ip/eslint-config-eyeo) you need [Node.js 7 or higher](https://nodejs.org/) and o nce it is installed please run `npm install` in the repository directory. 314 [configuration eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/t ip/eslint-config-eyeo) you need [Node.js 7 or higher](https://nodejs.org/) and o nce it is installed please run `npm install` in the repository directory.
310 315
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld