Delta Between Two Patch Sets: README.md
Issue 29825642:
Noissue - add 7z requirement into README.md (Closed)
Base URL: https://github.com/adblockplus/libadblockplus@d361cdf75c6c5af2aaa9b484092ded6c0a1dc441
Left Patch Set:
Created July 9, 2018, 2:08 p.m.
Right Patch Set: address comments
Created July 9, 2018, 3:20 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« no previous file
|
no next file »
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 libadblockplus | 1 libadblockplus |
| 2 ============== | 2 ============== |
| 3 | 3 |
| 4 A C++ library offering the core functionality of Adblock Plus. | 4 A C++ library offering the core functionality of Adblock Plus. |
| 5 | 5 |
| 6 Getting/updating the dependencies | 6 Getting/updating the dependencies |
| 7 --------------------------------- | 7 --------------------------------- |
| 8 | 8 |
| 9 libadblockplus has dependencies that aren't part of this repository. They are | 9 libadblockplus has dependencies that aren't part of this repository. They are |
| 10 retrieved and updated during the build process, but you can also manually update | 10 retrieved and updated during the build process, but you can also manually update |
| (...skipping 10 matching lines...) Expand all Loading... | |
| 21 Building | 21 Building |
| 22 -------- | 22 -------- |
| 23 | 23 |
| 24 ### Supported target platforms and prerequisites | 24 ### Supported target platforms and prerequisites |
| 25 | 25 |
| 26 General: | 26 General: |
| 27 * You need a C++14 compatible compiler to build libadblockplus. Below there is | 27 * You need a C++14 compatible compiler to build libadblockplus. Below there is |
| 28 the list of tested tools. | 28 the list of tested tools. |
| 29 | 29 |
| 30 * 7z | 30 * 7z |
| 31 We use 7z for prebuilt V8. In order to install it on e.g. debian based system | 31 We use 7z for prebuilt V8. In order to install it on a debian-based system |
| 32 one can use `p7zip-full` package and `p7zip` on rpm based. | 32 one can use `p7zip-full` package and `p7zip-plugins` on rpm-based. |
|
sergei
2018/07/09 14:11:16
@Hubert, could you please confirm that it's correc
hub
2018/07/09 14:44:39
On Fedora 28, `7z` is in `p7zip-plugins`. `p7zip`
sergei
2018/07/09 15:20:31
Acknowledged.
|
hub
2018/07/13 14:39:36
I'd write
"one can use `p7zip-full` package, or
sergei
2018/08/20 10:07:34
Done.
|
| 33 | 33 |
| 34 Win32: | 34 Win32: |
| 35 * At least v141 Visual C++ toolset (available in Microsoft Visual Studio 2017). | 35 * At least v141 Visual C++ toolset (available in Microsoft Visual Studio 2017). |
| 36 | 36 |
| 37 Linux: | 37 Linux: |
| 38 * clang 5.0 | 38 * clang 5.0 |
| 39 We use libc++ instead of the libstdc++ that gcc uses, since by default v8 build | 39 We use libc++ instead of the libstdc++ that gcc uses, since by default v8 build |
| 40 with libc++. | 40 with libc++. |
| 41 | 41 |
| 42 Mac: | 42 Mac: |
| (...skipping 263 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 306 Linting | 306 Linting |
| 307 ------- | 307 ------- |
| 308 | 308 |
| 309 You can lint the code using [ESLint](http://eslint.org). | 309 You can lint the code using [ESLint](http://eslint.org). |
| 310 | 310 |
| 311 npm run eslint | 311 npm run eslint |
| 312 | 312 |
| 313 In order to set up ESLint and | 313 In order to set up ESLint and |
| 314 [configuration eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/t ip/eslint-config-eyeo) you need [Node.js 7 or higher](https://nodejs.org/) and o nce it is installed please run `npm install` in the repository directory. | 314 [configuration eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/t ip/eslint-config-eyeo) you need [Node.js 7 or higher](https://nodejs.org/) and o nce it is installed please run `npm install` in the repository directory. |
| 315 | 315 |
| LEFT | RIGHT |
« no previous file
|
no next file »
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
