Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29827646: Issue 6783 - opt-in to anti circumvention filter list on upgrade (Closed)

Created:
July 12, 2018, 2:24 a.m. by hub
Modified:
July 17, 2018, 2:37 p.m.
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

Issue 6783 - opt-in to anti circumvention filter list on upgrade

Patch Set 1 #

Total comments: 3

Patch Set 2 : Don't re-ad default easylist #

Total comments: 2

Patch Set 3 : Updated comments #

Total comments: 7

Patch Set 4 : Updated comments #

Total comments: 4

Patch Set 5 : Change the name of the preference key #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -6 lines) Patch
M lib/prefs.js View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M lib/subscriptionInit.js View 1 2 3 4 3 chunks +15 lines, -6 lines 0 comments Download

Messages

Total messages: 13
hub
July 12, 2018, 2:24 a.m. (2018-07-12 02:24:37 UTC) #1
Manish Jethani
https://codereview.adblockplus.org/29827646/diff/29827647/lib/subscriptionInit.js File lib/subscriptionInit.js (right): https://codereview.adblockplus.org/29827646/diff/29827647/lib/subscriptionInit.js#newcode215 lib/subscriptionInit.js:215: if (shouldAddDefaultSubscription() || !Prefs.subscriptions_checkedanticv) But this will add an ...
July 12, 2018, 7:54 a.m. (2018-07-12 07:54:28 UTC) #2
kzar
https://codereview.adblockplus.org/29827646/diff/29827647/lib/subscriptionInit.js File lib/subscriptionInit.js (right): https://codereview.adblockplus.org/29827646/diff/29827647/lib/subscriptionInit.js#newcode215 lib/subscriptionInit.js:215: if (shouldAddDefaultSubscription() || !Prefs.subscriptions_checkedanticv) On 2018/07/12 07:54:27, Manish Jethani ...
July 12, 2018, 10:07 a.m. (2018-07-12 10:07:59 UTC) #3
hub
Updated patch. https://codereview.adblockplus.org/29827646/diff/29827647/lib/subscriptionInit.js File lib/subscriptionInit.js (right): https://codereview.adblockplus.org/29827646/diff/29827647/lib/subscriptionInit.js#newcode215 lib/subscriptionInit.js:215: if (shouldAddDefaultSubscription() || !Prefs.subscriptions_checkedanticv) On 2018/07/12 10:07:59, ...
July 12, 2018, 5:14 p.m. (2018-07-12 17:14:09 UTC) #4
Manish Jethani
Looks good to me, except for the one comment. Let's get feedback from Dave and/or ...
July 13, 2018, 3:20 p.m. (2018-07-13 15:20:25 UTC) #5
hub
https://codereview.adblockplus.org/29827646/diff/29828607/lib/subscriptionInit.js File lib/subscriptionInit.js (right): https://codereview.adblockplus.org/29827646/diff/29828607/lib/subscriptionInit.js#newcode214 lib/subscriptionInit.js:214: // Ensure the Anti Circumvention is added on upgrade. ...
July 13, 2018, 5:24 p.m. (2018-07-13 17:24:00 UTC) #6
kzar
https://codereview.adblockplus.org/29827646/diff/29829608/lib/subscriptionInit.js File lib/subscriptionInit.js (right): https://codereview.adblockplus.org/29827646/diff/29829608/lib/subscriptionInit.js#newcode61 lib/subscriptionInit.js:61: * Determines whether to add the default ad blocking ...
July 16, 2018, 1:39 p.m. (2018-07-16 13:39:23 UTC) #7
hub
Updated patch. https://codereview.adblockplus.org/29827646/diff/29829608/lib/subscriptionInit.js File lib/subscriptionInit.js (right): https://codereview.adblockplus.org/29827646/diff/29829608/lib/subscriptionInit.js#newcode213 lib/subscriptionInit.js:213: // Add default ad blocking subscription (e.g. ...
July 16, 2018, 3:50 p.m. (2018-07-16 15:50:07 UTC) #8
kzar
LGTM https://codereview.adblockplus.org/29827646/diff/29831570/lib/subscriptionInit.js File lib/subscriptionInit.js (right): https://codereview.adblockplus.org/29827646/diff/29831570/lib/subscriptionInit.js#newcode249 lib/subscriptionInit.js:249: Prefs.subscriptions_checkedanticv = true; Nit: Maybe "added" instead of ...
July 16, 2018, 4:37 p.m. (2018-07-16 16:37:47 UTC) #9
hub
https://codereview.adblockplus.org/29827646/diff/29831570/lib/subscriptionInit.js File lib/subscriptionInit.js (right): https://codereview.adblockplus.org/29827646/diff/29831570/lib/subscriptionInit.js#newcode249 lib/subscriptionInit.js:249: Prefs.subscriptions_checkedanticv = true; On 2018/07/16 16:37:47, kzar wrote: > ...
July 16, 2018, 7:07 p.m. (2018-07-16 19:07:35 UTC) #10
kzar
https://codereview.adblockplus.org/29827646/diff/29831570/lib/subscriptionInit.js File lib/subscriptionInit.js (right): https://codereview.adblockplus.org/29827646/diff/29831570/lib/subscriptionInit.js#newcode249 lib/subscriptionInit.js:249: Prefs.subscriptions_checkedanticv = true; On 2018/07/16 19:07:35, hub wrote: > ...
July 17, 2018, 10:32 a.m. (2018-07-17 10:32:32 UTC) #11
hub
https://codereview.adblockplus.org/29827646/diff/29831570/lib/subscriptionInit.js File lib/subscriptionInit.js (right): https://codereview.adblockplus.org/29827646/diff/29831570/lib/subscriptionInit.js#newcode249 lib/subscriptionInit.js:249: Prefs.subscriptions_checkedanticv = true; On 2018/07/17 10:32:32, kzar wrote: > ...
July 17, 2018, 2:29 p.m. (2018-07-17 14:29:28 UTC) #12
kzar
July 17, 2018, 2:30 p.m. (2018-07-17 14:30:34 UTC) #13
LGTM

Powered by Google App Engine
This is Rietveld