Issue 6783 - opt-in to anti circumvention filter list on upgrade

lib/subscriptionInit.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 193 matching lines @@
     {
       let antiAdblockSubscription = Subscription.fromURL(
         Prefs.subscriptions_antiadblockurl
       );
       antiAdblockSubscription.disabled = true;
       subscriptions.push(antiAdblockSubscription);
     }
   }
 
   // Add default ad blocking subscription (e.g. EasyList)
-  if (shouldAddDefaultSubscription())
+  // Ensure the Anti Circumvention is added on upgrade.
+  if (shouldAddDefaultSubscription() || !Prefs.subscriptions_checkedanticv)

[Manish Jethani, 2018/07/12 07:54:27]

But this will add an "ads" list as well. Shouldn't there be an additional check
somewhere to add only the "circumvention" list?

[kzar, 2018/07/12 10:07:59]

Yea, this logic doesn't look right.

Perhaps split out a function to add and enable default subscriptions, then just
hardcode the part that adds the anti-circumvention subscription if the
preference is falsey.

[hub, 2018/07/12 17:14:09]

This came to my mind before falling asleep. I'll fix it.

   {
     return fetch("subscriptions.xml")
       .then(response => response.text())
       .then(text =>
       {
         let doc = new DOMParser().parseFromString(text, "application/xml");
         let nodes = doc.getElementsByTagName("subscription");
 
         let defaultSubscriptions = chooseFilterSubscriptions(nodes);
         if (defaultSubscriptions)
         {
           for (let name in defaultSubscriptions)
           {
             let node = defaultSubscriptions[name];
             if (!node)
               continue;
 
             let url = node.getAttribute("url");
             if (url)
             {
               let subscription = Subscription.fromURL(url);
               subscription.disabled = false;
               subscription.title = node.getAttribute("title");
               subscription.homepage = node.getAttribute("homepage");
               subscription.type = node.getAttribute("type");
               subscriptions.push(subscription);
+              if (subscription.type == "circumvention")
+                Prefs.subscriptions_checkedanticv = true;
             }
           }
         }
 
         return subscriptions;
       });
   }
 
   return subscriptions;
 }
@@ skipping 73 matching lines @@
  *
  * @param {function} callback
  */
 exports.setSubscriptionsCallback = callback =>
 {
   subscriptionsCallback = callback;
 };
 
 // Exports for tests only
 exports.chooseFilterSubscriptions = chooseFilterSubscriptions;