Issue 6790 - Implement uabinject-defuser snippet

Based on https://codereview.adblockplus.org/29829569/

[Manish Jethani, 2018-07-12 16:34:09]

Patch Set 1

[Manish Jethani, 2018-07-13 10:38:15]

Patch Set 2: Fix ESLint error

[Manish Jethani, 2018-07-13 10:44:36]

Patch Set 3: Use strict mode in injected code

[Manish Jethani, 2018-07-13 12:59:42]

Patch Set 4: Add attribution

[Manish Jethani, 2018-07-13 14:35:31]

Patch Set 5: Rebase on patch #29829569

[kzar, 2018-07-16 14:25:30]

Code itself LGTM.

However, before you push this, I'd like to see Kai/Felix confirm about
attribution and the legal stuff. In the comment you mention something like
"based on the implementation...", but in my opinion, you took his exact code and
then added some new lines.

I wonder, if the plan is to keep taking the snippets from uBlock, why can't we
just take them verbatim, and give full credit? I don't like this dance.

[Manish Jethani, 2018-07-17 10:00:01]

On 2018/07/16 14:25:30, kzar wrote:
> Code itself LGTM.
> 
> However, before you push this, I'd like to see Kai/Felix confirm about
> attribution and the legal stuff. In the comment you mention something like
> "based on the implementation...", but in my opinion, you took his exact code
and
> then added some new lines.

Whether I hit Ctrl+C Ctrl+V on that one line of code and then modified it, or I
just typed out these four lines by referring to the original code, is a
technicality.
 
> I wonder, if the plan is to keep taking the snippets from uBlock, why can't we
> just take them verbatim, and give full credit? I don't like this dance.

Are you serious!?

We cannot use uBlock Origin's code because it doesn't fit in our framework, it
doesn't follow the same coding style, it is not even the same language (ES2015).
We _need_ a different implementation written to work with our framework, follow
our coding style, and implemented in ES2015. What dance are you talking about?
We need a different implementation, period.

I tried to copy the code and then "slightly" modify it, but I ended up having to
modify it significantly. I threw it away and wrote from scratch instead. We will
have to do this for every technique that we learn from uBlock Origin: learn how
it is done, then implement for Adblock Plus. This is what I am doing now.

[kzar, 2018-07-17 10:25:07]

Well, like I say I defer to Sebastian/Felix regarding attribution and related
legal stuff.

[Manish Jethani, 2018-07-24 14:02:27]

Thanks!