eslint-config-eyeo/package.json - Issue 29829605: Noissue - updating eslint dependency to v5

Delta Between Two Patch Sets: eslint-config-eyeo/package.json

Issue 29829605: Noissue - updating eslint dependency to v5 (Closed)

Left Patch Set: Created July 13, 2018, 4:04 p.m.

Right Patch Set: Created July 18, 2018, 10:36 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 {	1 {

2 "name": "eslint-config-eyeo",	2 "name": "eslint-config-eyeo",

3 "version": "2.0.0",	3 "version": "2.0.0",

4 "description": "ESLint configuration as used by eyeo.",	4 "description": "ESLint configuration as used by eyeo.",

5 "main": "index.js",	5 "main": "index.js",

6 "repository": {	6 "repository": {

7 "type": "hg",	7 "type": "hg",

8 "url": "https://hg.adblockplus.org/codingtools"	8 "url": "https://hg.adblockplus.org/codingtools"

9 },	9 },

10 "keywords": [	10 "keywords": [

11 "eyeo",	11 "eyeo",

12 "adblockplus",	12 "adblockplus",

13 "abp",	13 "abp",

14 "eslint",	14 "eslint",

15 "eslintconfig"	15 "eslintconfig"

16 ],	16 ],

17 "author": {	17 "author": {

18 "name": "eyeo GmbH",	18 "name": "eyeo GmbH",

19 "url": "https://eyeo.com/"	19 "url": "https://eyeo.com/"

20 },	20 },

21 "license": "GPL-3.0",	21 "license": "GPL-3.0",

22 "bugs": {	22 "bugs": {

23 "url": "https://issues.adblockplus.org/"	23 "url": "https://issues.adblockplus.org/"

24 },	24 },

25 "peerDependencies": {	25 "peerDependencies": {

26 "eslint": "5"	26 "eslint": "^5.1"
Sebastian Noack 2018/07/13 16:13:47 As far as I understand, this would request ==5.0.0 As far as I understand, this would request ==5.0.0 (but there is already 5.1). I guess what we want here is ^5.1 (which means >=5.1,<5.2 or in other words give me the latest version compatible with 5.1). That way, if there will be any security (or otherwise critical) issue with 5.1.0 and they release 5.1.1 as a hotfix, we automatically get it. But an upgrade to 5.2 (or above) which might require further changes on our end would still need to be performed manually. tlucas 2018/07/13 16:22:30 With npm's "semver" thingy in place, this would (c Show quoted text On 2018/07/13 16:13:47, Sebastian Noack wrote: > As far as I understand, this would request ==5.0.0 (but there is already 5.1). > > I guess what we want here is ^5.1 (which means >=5.1,<5.2 or in other words give > me the latest version compatible with 5.1). That way, if there will be any > security (or otherwise critical) issue with 5.1.0 and they release 5.1.1 as a > hotfix, we automatically get it. But an upgrade to 5.2 (or above) which might > require further changes on our end would still need to be performed manually. With npm's "semver" thingy in place, this would (confirmed locally) request the latest version of the major version 5 (in my case, it did install v5.1.0 [ by calling 'npm install eslint@5]) however, i wouldn't mind pinning this a bit tighter. But to specifically get only patches for 5.1 , we should go with 5.1.x. Sebastian Noack 2018/07/13 17:06:57 You seem to be right. I initially misunderstood th Show quoted text On 2018/07/13 16:22:30, tlucas wrote: > On 2018/07/13 16:13:47, Sebastian Noack wrote: > > As far as I understand, this would request ==5.0.0 (but there is already 5.1). > > > > I guess what we want here is ^5.1 (which means >=5.1,<5.2 or in other words > give > > me the latest version compatible with 5.1). That way, if there will be any > > security (or otherwise critical) issue with 5.1.0 and they release 5.1.1 as a > > hotfix, we automatically get it. But an upgrade to 5.2 (or above) which might > > require further changes on our end would still need to be performed manually. > > With npm's "semver" thingy in place, this would (confirmed locally) request the > latest version of the major version 5 (in my case, it did install v5.1.0 [ by > calling 'npm install eslint@5]) however, i wouldn't mind pinning this a bit > tighter. But to specifically get only patches for 5.1 , we should go with 5.1.x. You seem to be right. I initially misunderstood the simplified documentation in the "dependencies" section for package.json [1]. However, in the detailed semver documentation [2] it clearly confirms what you are saying. I personally wouldn't mind a slightly broader requirement. But since we never tested it with ESLint 5.0, we might still want to go with ^5.1 after all. [1]: https://docs.npmjs.com/files/package.json#dependencies [2]: https://docs.npmjs.com/misc/semver tlucas 2018/07/18 10:37:34 Acknowledged and done. Show quoted text On 2018/07/13 17:06:57, Sebastian Noack wrote: > On 2018/07/13 16:22:30, tlucas wrote: > > On 2018/07/13 16:13:47, Sebastian Noack wrote: > > > As far as I understand, this would request ==5.0.0 (but there is already > 5.1). > > > > > > I guess what we want here is ^5.1 (which means >=5.1,<5.2 or in other words > > give > > > me the latest version compatible with 5.1). That way, if there will be any > > > security (or otherwise critical) issue with 5.1.0 and they release 5.1.1 as > a > > > hotfix, we automatically get it. But an upgrade to 5.2 (or above) which > might > > > require further changes on our end would still need to be performed > manually. > > > > With npm's "semver" thingy in place, this would (confirmed locally) request > the > > latest version of the major version 5 (in my case, it did install v5.1.0 [ by > > calling 'npm install eslint@5]) however, i wouldn't mind pinning this a bit > > tighter. But to specifically get only patches for 5.1 , we should go with > 5.1.x. > > You seem to be right. I initially misunderstood the simplified documentation in > the "dependencies" section for package.json [1]. However, in the detailed semver > documentation [2] it clearly confirms what you are saying. > > I personally wouldn't mind a slightly broader requirement. But since we never > tested it with ESLint 5.0, we might still want to go with ^5.1 after all. > > [1]: https://docs.npmjs.com/files/package.json#dependencies > [2]: https://docs.npmjs.com/misc/semver Acknowledged and done.
27 }	27 }

28 }	28 }

LEFT	RIGHT