Noissue - updating eslint dependency to v5

eslint-config-eyeo/package.json

Index: eslint-config-eyeo/package.json
diff --git a/eslint-config-eyeo/package.json b/eslint-config-eyeo/package.json
index 875b2169ad899980d2f4ab8bc0b75ecc654b1d5e..0421c276a3f7e50e4cb298cdf4cc5a66bf65221e 100644
--- a/eslint-config-eyeo/package.json
+++ b/eslint-config-eyeo/package.json
@@ -23,6 +23,6 @@
     "url": "https://issues.adblockplus.org/"
   },
   "peerDependencies": {
-    "eslint": "4"
+    "eslint": "5"

[Sebastian Noack, 2018/07/13 16:13:47]

As far as I understand, this would request ==5.0.0 (but there is already 5.1).

I guess what we want here is ^5.1 (which means >=5.1,<5.2 or in other words give
me the latest version compatible with 5.1). That way, if there will be any
security (or otherwise critical) issue with 5.1.0 and they release 5.1.1 as a
hotfix, we automatically get it. But an upgrade to 5.2 (or above) which might
require further changes on our end would still need to be performed manually.

[tlucas, 2018/07/13 16:22:30]

With npm's "semver" thingy in place, this would (confirmed locally) request the
latest version of the major version 5 (in my case, it did install v5.1.0 [ by
calling 'npm install eslint@5]) however, i wouldn't mind pinning this a bit
tighter. But to specifically get only patches for 5.1 , we should go with 5.1.x.

[Sebastian Noack, 2018/07/13 17:06:57]

You seem to be right. I initially misunderstood the simplified documentation in
the "dependencies" section for package.json [1]. However, in the detailed semver
documentation [2] it clearly confirms what you are saying.

I personally wouldn't mind a slightly broader requirement. But since we never
tested it with ESLint 5.0, we might still want to go with ^5.1 after all.

[1]: https://docs.npmjs.com/files/package.json#dependencies
[2]: https://docs.npmjs.com/misc/semver

[tlucas, 2018/07/18 10:37:34]

Acknowledged and done.

   }
 }