Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(156)

Issue 29829615: Issue 6786 - Switch Safari 12+ users to content blocking API (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 3 months ago by kzar
Modified:
1 year, 3 months ago
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 6786 - Switch Safari 12+ users to content blocking API

Patch Set 1 #

Total comments: 2

Patch Set 2 : Prevent Safari 12+ users switch content blocking mode off #

Total comments: 2

Patch Set 3 : Simplify Safari version parsing logic #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -28 lines) Patch
M options.js View 1 2 2 chunks +9 lines, -4 lines 0 comments Download
M safari/contentBlocking.js View 1 chunk +1 line, -1 line 0 comments Download
M safari/ext/content.js View 1 2 3 chunks +36 lines, -23 lines 0 comments Download

Messages

Total messages: 5
kzar
Patch Set 1
1 year, 3 months ago (2018-07-13 18:18:51 UTC) #1
kzar
Patch Set 2 : Prevent Safari 12+ users switch content blocking mode off
1 year, 3 months ago (2018-07-13 18:24:09 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29829615/diff/29829616/options.js File options.js (right): https://codereview.adblockplus.org/29829615/diff/29829616/options.js#newcode21 options.js:21: var majorApplicationVersion = parseInt(applicatonVersion.split(".")[0], 10); If you remove the ...
1 year, 3 months ago (2018-07-13 18:27:54 UTC) #3
kzar
Patch Set 3 : Simplify Safari version parsing logic https://codereview.adblockplus.org/29829615/diff/29829616/options.js File options.js (right): https://codereview.adblockplus.org/29829615/diff/29829616/options.js#newcode21 options.js:21: ...
1 year, 3 months ago (2018-07-13 18:58:33 UTC) #4
Sebastian Noack
1 year, 3 months ago (2018-07-13 19:03:43 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5