Issue 6774 - $document doesn't whitelist everything inside iframes in Edge

ext/background.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 542 matching lines @@
         // (protocol ms-browser-extension://) do no have a sender URL.
         url: rawSender.url ? new URL(rawSender.url) : null,
         get parent()
         {
           let frames = framesOfTabs.get(rawSender.tab.id);
 
           if (!frames)
             return null;
 
           let frame;
-          // In Edge we don't have frameId

[kzar, 2018/07/17 14:46:07]

Would be nice to add an Edge version number, so in the future it's easier to see
if we can remove the workaround.

[Sebastian Noack, 2018/07/17 14:50:34]

Also please spell out "Microsoft Edge".

[geo, 2018/07/17 16:36:21]

Done.

[geo, 2018/07/17 16:36:22]

Done.

+          // In Microsoft Edge (version 42.17134.1.0) we don't have frameId
           // so we fall back to iterating over the tab's frames
           // see https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/11716733
           if (rawSender.frameId != undefined)
             frame = frames.get(rawSender.frameId);
-          else
+          else if (rawSender.url)
           {
-            for (let [key, value] of frames)
+            let rawSenderHref = rawSender.url.replace(/#.*/, "");
+
+            for (let [frameId, frameInfo] of frames)
             {
-              let valueHref = value.url.href.replace("#", "");

[Sebastian Noack, 2018/07/17 14:20:42]

This will only strip the # character itself but not the part that follows.

Just in case, does value.url include the hash part anyway?

[geo, 2018/07/17 16:36:21]

I'm sorry. I've fixed it.
Yes, both value.url and rawSender.url have the hash part.  

-
-              let rawSenderHref = rawSender.url ?

[Sebastian Noack, 2018/07/17 14:20:42]

Under which circumstances is url undefined or null?

[geo, 2018/07/17 16:36:21]

I've based that off the comment at
https://codereview.adblockplus.org/29832561/diff/29832562/ext/background.js#n...

-                rawSender.url.replace("#", "") :

[Sebastian Noack, 2018/07/17 14:20:41]

This will only strip the # character itself but not the part that follows.

Just in case, does rawSender.url include the hash part anyway?

[geo, 2018/07/17 16:36:21]

Done.

-                "";
-
-              if (valueHref == rawSenderHref)

[kzar, 2018/07/17 14:46:07]

I wonder what will happen if two frames have the same URL?

[Sebastian Noack, 2018/07/17 14:50:34]

Then we assume that it's the first of the two frames. It's the best we can do.

[kzar, 2018/07/17 15:41:53]

Fair enough, but maybe we should leave a comment here to explain the limitation?

[geo, 2018/07/17 16:36:22]

Done.

+              let frameInfoHref = frameInfo.url.href.replace(/#.*/, "");
+
+              // If we have two frames with the same URL
+              // we are going to pick the first one we find
+              // as we have no other way of distinguishing between them.
+              if (frameInfoHref == rawSenderHref)
               {
-                frame = value;
-                this.id = key;
+                frame = frameInfo;
+                this.id = frameId;
                 break;
               }
             }
           }
 
           if (frame)
             return frame.parent || null;
           return frames.get(0) || null;
         }
       };
     }
 
     return ext.onMessage._dispatch(
       message, sender, sendResponse
     ).includes(true);
   });
 }