sitescripts/oauth2dl/bin/constants.py - Issue 29833582: Issue 4954 - Implement a downloader script supporting OAuth2 authentication/authorization

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: sitescripts/oauth2dl/bin/constants.py

Issue 29833582: Issue 4954 - Implement a downloader script supporting OAuth2 authentication/authorization (Closed)

Patch Set: Created July 18, 2018, 1:41 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # This file is part of the Adblock Plus web scripts,

	2 # Copyright (C) 2006-present eyeo GmbH

	3 #

	4 # Adblock Plus is free software: you can redistribute it and/or modify

	5 # it under the terms of the GNU General Public License version 3 as

	6 # published by the Free Software Foundation.

	7 #

	8 # Adblock Plus is distributed in the hope that it will be useful,

	9 # but WITHOUT ANY WARRANTY; without even the implied warranty of

	10 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

	11 # GNU General Public License for more details.

	12 #

	13 # You should have received a copy of the GNU General Public License

	14 # along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.

	15

	16 KEYFILE_NOT_FOUND_ERROR = 'ERROR: Oauth2 key file not found! Please specify ' \
	Vasily Kuznetsov 2018/07/20 21:00:00 PEP8 [1] recommends breaking long lines by implied PEP8 [1] recommends breaking long lines by implied continuation inside parentheses instead of using backslashes when possible. What do you think about following this and rewriting these constants like this: KEYFILE_NOT_FOUND_ERROR = ( 'ERROR: Oauth2 key file not found! Please specify ' 'it as an optional argument using -k or --key or ' ... ) [1]: https://www.python.org/dev/peps/pep-0008/?#maximum-line-length Tudor Avram 2018/07/31 09:20:16 Done. Show quoted text On 2018/07/20 21:00:00, Vasily Kuznetsov wrote: > PEP8 [1] recommends breaking long lines by implied continuation inside > parentheses instead of using backslashes when possible. What do you think about > following this and rewriting these constants like this: > > KEYFILE_NOT_FOUND_ERROR = ( > 'ERROR: Oauth2 key file not found! Please specify ' > 'it as an optional argument using -k or --key or ' > ... > ) > > [1]: https://www.python.org/dev/peps/pep-0008/#maximum-line-length Done.
	17 'it as an optional argument using -k or --key or ' \

	18 'add it to the environment variable OAUTH2DL_KEY.'

	19

	20 SCOPE_NOT_FOUND_ERROR = 'ERROR: Oauth2 scope not found! Please specify it ' \

	21 'as an optional argument using -s or --scope or add ' \

	22 'it to the environment variable OAUTH2DL_SCOPE'

	23

	24 INVALID_KEY_FILE = 'ERROR: Invalid key file format! {0} not found in {1}!'

	25

	26 DUMMY_PRIVATE_KEY = '-----BEGIN RSA PRIVATE KEY-----\nMIIBOgIBAAJBAK8Q+ToR4t' \

	27 'WGshaKYRHKJ3ZmMUF6jjwCS/u1A8v1tFbQiVpBlxYB\npaNcT2ENEXB' \

	28 'GdmWqr8VwSl0NBIKyq4p0rhsCAQMCQHS1+3wL7I5ZzA8G62Exb6RE\n' \

	29 'INZRtCgBh/0jV91OeDnfQUc07SE6vs31J8m7qw/rxeB3E9h6oGi9IVR' \

	30 'ebVO+9zsC\nIQDWb//KAzrSOo0P0yktnY57UF9Q3Y26rulWI6LqpsxZ' \

	31 'DwIhAND/cmlg7rUz34Pf\nSmM61lJEmMEjKp8RB/xgghzmCeI1AiEAj' \

	32 'vVVMVd8jCcItTdwyRO0UjWU4JOz0cnw\n5BfB8cSIO18CIQCLVPbw60' \

	33 'nOIpUClNxCJzmMLbsrbMcUtgVS6wFomVvsIwIhAK+A\nYqT6WwsMW2O' \

	34 'n5l9di+RPzhDT1QdGyTI5eFNS+GxY\n-----END RSA PRIVATE KEY' \

	35 '-----'

	36

	37 GOOGLE_OAUTH_ERROR = 'ERROR {0} - {1}'

OLD	NEW

« .gitignore ('K') | « sitescripts/oauth2dl/bin/__init__.py ('k') | sitescripts/oauth2dl/bin/oauth2dl.py » ('j') | sitescripts/oauth2dl/bin/oauth2dl.py » ('J')