Issue 4954 - Implement a downloader script supporting OAuth2 authentication/authorization

tox.ini

 [tox]
 envlist = py27
 skipsdist = true
 
 [pytest]
 # The names of the test files here don't start with 'test_' so we need
-# to instruct pytest to load tests from all files.
+# to instruct pytest to load test from all files.
 python_files = *.py
 
 [run]
-# Exclude tests from coverage.
+# Exclude test from coverage.
 omit = */test/*
 
 [flake8]
 ignore = D1
 per-file-ignores =
     /sitescripts/content_blocker_lists/bin/generate_lists.py : A107,E501
     /sitescripts/crashes/web/submitCrash.py : A302,E501,E711,F401,N802,N806
     /sitescripts/crawler/bin/import_sites.py : A105,A206,E501
     /sitescripts/crawler/web/crawler.py : A107,A108,A206,E501
     /sitescripts/extensions/bin/createNightlies.py : A102,A104,A107,A108,A302,D200,D202,D205,D208,D400,D401,D403,E501,E722,F841,N802,N806,N812
@@ skipping 48 matching lines @@
     /sitescripts/subscriptions/test/test_updateMalwareDomainsList.py : D400,D401
     /sitescripts/subscriptions/web/fallback.py : A107,A206,A301,E501,F401,N802,N806
     /sitescripts/templateFilters.py : A107,A112,A206,E501,E711,F401,F841,N802,N803,N806
     /sitescripts/testpages/web/sitekey_frame.py : A107
     /sitescripts/urlfixer/bin/forceDomains.py : A206,D205,D400,E501,N802
     /sitescripts/urlfixer/bin/topDomains.py : A206,D205,D400,E501,E711,F401,N802
     /sitescripts/urlfixer/web/submitData.py : A206,E501,E711,F401,F841,N802,N806
     /sitescripts/utils.py : A107,A301,D200,D202,D205,D208,D400,D401,E501,N801,N802,N806
     /sitescripts/web.py : A107,E501,N802
     /multiplexer.py : A107,E501
+    /sitescripts/oauth2dl/bin/oauth2dl.py: D413, E501, A301

[Vasily Kuznetsov, 2018/07/20 21:00:01]

It would be better not to add exceptions for new code. Is any of this really
necessary or can we adjust the code to make flake8 happy?

[Tudor Avram, 2018/07/31 09:20:18]

Done.

+    /sitescripts/oauth2dl/test/test_oauth2dl.py: A110
+    sitescripts/oauth2dl/utils/dummy_wsgi_app.py: A206
 
 [testenv]
 basepython=python2
 deps =
     cryptography
     pytest
     pytest-cov
     mock
     pytest-mock
     wsgi_intercept
     jinja2
     pycrypto
     pysed
     flake8
     flake8-per-file-ignores>=0.4
     flake8-docstrings
     flake8-commas
     pep8-naming
     hg+https://hg.adblockplus.org/codingtools#egg=flake8-eyeo&subdirectory=flake8-eyeo
+    httplib2

[Vasily Kuznetsov, 2018/07/20 21:00:01]

Do we need httplib2 for the new script? Do Google libraries require it or what's
the reason?

[Tudor Avram, 2018/07/23 19:29:03]

Yeah, the google library requires an `httplib2.Http()` object to be passed to
them. From my understanding, they are using the respective object to make the
requests to their API.

[Tudor Avram, 2018/07/31 09:20:19]

Done.

+    oauth2client
 
 setenv =
     SITESCRIPTS_CONFIG = ./.sitescripts.test
 whitelist_externals = cp
 commands =
     cp .sitescripts.example .sitescripts.test
     pysed \
         -r sitescripts\.(reports|testpages|crawler|urlfixer)\.web.* \
         '' .sitescripts.test --write
     python ensure_dependencies.py
     py.test \
         --cov-config tox.ini --cov-report html --cov-report term --cov sitescripts \
         sitescripts/hg/test \
         sitescripts/notifications/test \
         sitescripts/stats/test \
         sitescripts/formmail/test \
         sitescripts/extensions/test \
         sitescripts/subscriptions/test \
         sitescripts/reports/tests \
+    sitescripts/oauth2dl/test/test_oauth2dl.py \

[Vasily Kuznetsov, 2018/07/20 21:00:01]

Would be neater to keep consistent indentation.

[Tudor Avram, 2018/07/23 19:29:03]

Acknowledged.

[Tudor Avram, 2018/07/31 09:20:18]

Done.

         tests
     flake8 sitescripts multiplexer.py multiplexer.fcgi