Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1051)

Issue 29833597: Issue 6784 - Upgrade adblockpluscore to 658f0229baa1 and adblockplusui to 9a652397b9af (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 4 months ago by hub
Modified:
1 year, 3 months ago
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

Issue 6784 - Upgrade adblockpluscore to 658f0229baa1 and adblockplusui to 9a652397b9af

Patch Set 1 #

Patch Set 2 : Update revision #

Patch Set 3 : Bump revisions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M dependencies View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 20
hub
1 year, 4 months ago (2018-07-18 17:59:44 UTC) #1
kzar
On 2018/07/18 17:59:44, hub wrote: Aren't there still changes which need to land in adblockpluscore ...
1 year, 4 months ago (2018-07-18 18:46:11 UTC) #2
hub
Right. Let's revisit this review when the rest has landed (I'll update). Albeit we'll need ...
1 year, 4 months ago (2018-07-18 21:58:12 UTC) #3
Manish Jethani
On 2018/07/18 21:58:12, hub wrote: > Also we'll still be missing the UI change for ...
1 year, 4 months ago (2018-07-18 23:33:41 UTC) #4
hub
On 2018/07/18 23:33:41, Manish Jethani wrote: > On 2018/07/18 21:58:12, hub wrote: > > > ...
1 year, 4 months ago (2018-07-18 23:58:19 UTC) #5
hub
patch updated
1 year, 4 months ago (2018-07-19 02:58:53 UTC) #6
Manish Jethani
LGTM But let's wait for the go-ahead from Dave or Sebastian.
1 year, 4 months ago (2018-07-19 10:37:41 UTC) #7
kzar
Please could you update the issue description? It doesn't include any testing information for example. ...
1 year, 4 months ago (2018-07-19 12:31:29 UTC) #8
hub
On 2018/07/19 12:31:29, kzar wrote: > Please could you update the issue description? It doesn't ...
1 year, 4 months ago (2018-07-19 15:46:53 UTC) #9
kzar
On 2018/07/19 15:46:53, hub wrote: > On 2018/07/19 12:31:29, kzar wrote: > > Please could ...
1 year, 4 months ago (2018-07-19 16:02:54 UTC) #10
kzar
> Issue 6784 - Upgrade adblockpluscore to 8e466288a0c3 Also, please could you adjust the commit ...
1 year, 4 months ago (2018-07-19 16:43:10 UTC) #11
Manish Jethani
While we're still not done with this, can we also include the hide-if-shadow-contains snippet? https://hg.adblockplus.org/adblockpluscore/rev/658f0229baa1 ...
1 year, 4 months ago (2018-07-19 17:03:45 UTC) #12
hub
On 2018/07/19 17:03:45, Manish Jethani wrote: > While we're still not done with this, can ...
1 year, 4 months ago (2018-07-19 17:28:07 UTC) #13
Manish Jethani
On 2018/07/19 17:28:07, hub wrote: > On 2018/07/19 17:03:45, Manish Jethani wrote: > > While ...
1 year, 4 months ago (2018-07-19 19:47:10 UTC) #14
hub
On 2018/07/19 19:47:10, Manish Jethani wrote: > Shouldn't we also update the commit message here ...
1 year, 4 months ago (2018-07-19 19:57:43 UTC) #15
Manish Jethani
LGTM from my end
1 year, 4 months ago (2018-07-19 20:06:45 UTC) #16
kzar
(This change is still blocked by the issue description. Especially testing hints and confirmation that ...
1 year, 3 months ago (2018-07-20 09:23:42 UTC) #17
Manish Jethani
On 2018/07/20 09:23:42, kzar wrote: > (This change is still blocked by the issue description. ...
1 year, 3 months ago (2018-07-20 11:25:50 UTC) #18
kzar
On 2018/07/20 11:25:50, Manish Jethani wrote: > On 2018/07/20 09:23:42, kzar wrote: > > (This ...
1 year, 3 months ago (2018-07-20 11:28:22 UTC) #19
kzar
1 year, 3 months ago (2018-07-20 15:48:02 UTC) #20
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5