Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/content/snippets.js

Issue 29835561: Issue 6803 - Implement readd snippet (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Created July 20, 2018, 9:50 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/content/snippets.js
===================================================================
--- a/lib/content/snippets.js
+++ b/lib/content/snippets.js
@@ -115,16 +115,35 @@
{
element.style.setProperty("display", "none", "important");
}
})
.observe(element, {attributes: true, attributeFilter: ["style"]});
}
/**
+ * Observes changes to a DOM node using a <code>MutationObserver</code>.
+ *
+ * @param {Node} target The DOM node to observe for changes.
+ * @param {MutationObserverInit?} [options] Options that describe what DOM
+ * mutations should be reported to the callback.
+ * @param {function} callback A function that will be called on each DOM
+ * mutation, taking a <code>MutationRecord</code> as its parameter.
+ */
+function observe(target, options, callback)
+{
+ new MutationObserver(mutations =>
+ {
+ for (let mutation of mutations)
+ callback(mutation);
+ })
+ .observe(target, options);
+}
+
+/**
* Logs its arguments to the console. This may be used for testing and
* debugging.
*
* @param {...*} [args] The arguments to log.
*/
function log(...args)
{
console.log(...args);
@@ -222,8 +241,37 @@
return root;
}
});
}
exports["hide-if-shadow-contains"] = makeInjector(hideIfShadowContains,
hideElement);
+
+/**
+ * Untrashes a document by readding removed elements that match a CSS selector.
+ *
+ * @param {string} selector The CSS selector that a removed element should
+ * match for it to be added back.
+ * @param {string?} [parentSelector] The CSS selector that a removed element's
+ * former parent should match for it to be added back.
+ */
+function untrash(selector, parentSelector = null)
+{
+ observe(document, {childList: true, subtree: true}, mutation =>
+ {
+ if (!parentSelector || mutation.target.matches(parentSelector))
+ {
+ for (let node of mutation.removedNodes || [])
hub 2018/07/23 18:07:39 if mutation.removedNodes is falsey, we could just
Manish Jethani 2018/07/23 20:07:06 Makes sense, done.
+ {
+ if (node instanceof HTMLElement && node.matches(selector))
+ {
+ // We don't have the location of the element in its former parent,
+ // but it's usually OK to just add it at the end.
+ mutation.target.appendChild(node);
+ }
+ }
+ }
+ });
+}
+
+exports.untrash = untrash;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld