Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(768)

Issue 29836573: Issue 6809 - Implement hide-if-contains snippet (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 10 months ago by Manish Jethani
Modified:
1 year, 10 months ago
Reviewers:
kzar, hub
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M lib/content/snippets.js View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 5
Manish Jethani
1 year, 10 months ago (2018-07-23 23:11:45 UTC) #1
Manish Jethani
Patch Set 1 I'll update the Trac issue, but this is a complement to the ...
1 year, 10 months ago (2018-07-23 23:15:32 UTC) #2
Manish Jethani
Since #6804 is going to be more challenging to do, we should get this snippet ...
1 year, 10 months ago (2018-07-26 10:34:57 UTC) #3
hub
LGTM, but what the difference with :-abp-contains() ?
1 year, 10 months ago (2018-07-26 12:05:57 UTC) #4
Manish Jethani
1 year, 10 months ago (2018-07-26 12:10:51 UTC) #5
On 2018/07/26 12:05:57, hub wrote:
> LGTM, but what the difference with :-abp-contains() ?

Thanks!

:-abp-contains() runs only after the DOMContentLoaded event (see #6804), by
which time the ad has already been displayed for a second or two. When the ad is
hidden, everything shifts on the page. Overall this is a bad user experience.

Eventually we should address this in #6804 and then remove this snippet.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5