Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(490)

Issue 29841555: Issue 6814 - Avoid redundant calls to domains getter (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 8 months ago by Manish Jethani
Modified:
1 year, 8 months ago
Reviewers:
hub
CC:
kzar, sergei
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Fetch sitekeys as well #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M lib/filterClasses.js View 1 2 chunks +13 lines, -8 lines 1 comment Download

Messages

Total messages: 5
Manish Jethani
1 year, 8 months ago (2018-07-29 12:18:10 UTC) #1
Manish Jethani
Patch Set 1 Hubert, this is a simple change. Can you do a quick review ...
1 year, 8 months ago (2018-07-29 12:26:30 UTC) #2
Manish Jethani
Patch Set 2: Fetch sitekeys as well https://codereview.adblockplus.org/29841555/diff/29841561/lib/filterClasses.js File lib/filterClasses.js (right): https://codereview.adblockplus.org/29841555/diff/29841561/lib/filterClasses.js#newcode547 lib/filterClasses.js:547: let {sitekeys, ...
1 year, 8 months ago (2018-07-29 15:27:52 UTC) #3
hub
LGTM
1 year, 8 months ago (2018-07-30 14:48:27 UTC) #4
Manish Jethani
1 year, 8 months ago (2018-07-30 14:59:42 UTC) #5
On 2018/07/30 14:48:27, hub wrote:
> LGTM

Thank you!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5