Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(331)

Issue 29843566: Issue 6819 - Shadow globals in snippets

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 2 weeks ago by Manish Jethani
Modified:
3 weeks, 4 days ago
Reviewers:
kzar, hub
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Issue 6819 - Shadow globals in snippets

Patch Set 1 #

Total comments: 10
Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -2 lines) Patch
M lib/snippets.js View 1 chunk +38 lines, -1 line 8 comments Download
M test/snippets.js View 2 chunks +51 lines, -1 line 2 comments Download

Messages

Total messages: 6
Manish Jethani
2 months, 2 weeks ago (2018-07-31 14:10:04 UTC) #1
Manish Jethani
Patch Set 1 I found a way to achieve what I have described in #6819. ...
2 months, 2 weeks ago (2018-07-31 14:17:08 UTC) #2
hub
I'm not familiar with Proxy. I don't see anything wrong with this change though.
2 months, 2 weeks ago (2018-08-02 17:12:04 UTC) #3
Manish Jethani
On 2018/08/02 17:12:04, hub wrote: > I'm not familiar with Proxy. I don't see anything ...
2 months ago (2018-08-15 08:40:34 UTC) #4
hub
On 2018/08/15 08:40:34, Manish Jethani wrote: > On 2018/08/02 17:12:04, hub wrote: > > I'm ...
2 months ago (2018-08-16 01:30:43 UTC) #5
Manish Jethani
2 months ago (2018-08-16 04:56:33 UTC) #6
On 2018/08/16 01:30:43, hub wrote:
> On 2018/08/15 08:40:34, Manish Jethani wrote:
> > On 2018/08/02 17:12:04, hub wrote:
> > > I'm not familiar with Proxy. I don't see anything wrong with this change
> > though.
> > 
> > A Proxy is basically 
> 
> I know. My point is that I'm not confident enough about it. So if Dave can
> review as well, I'd feel better.

Makes sense, thanks.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5