Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(28)

Issue 29843566: Issue 6819 - Shadow globals in snippets

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 6 days ago by Manish Jethani
Modified:
1 week, 4 days ago
Reviewers:
hub, kzar
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Issue 6819 - Shadow globals in snippets

Patch Set 1 #

Total comments: 10
Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -2 lines) Patch
M lib/snippets.js View 1 chunk +38 lines, -1 line 8 comments Download
M test/snippets.js View 2 chunks +51 lines, -1 line 2 comments Download

Messages

Total messages: 3
Manish Jethani
1 week, 6 days ago (2018-07-31 14:10:04 UTC) #1
Manish Jethani
Patch Set 1 I found a way to achieve what I have described in #6819. ...
1 week, 6 days ago (2018-07-31 14:17:08 UTC) #2
hub
1 week, 4 days ago (2018-08-02 17:12:04 UTC) #3
I'm not familiar with Proxy. I don't see anything wrong with this change though.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5