Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29845576: Issue 6832 - Easylist was not re-added if the anti-circumvention list existed (Closed)

Created:
Aug. 2, 2018, 10:33 p.m. by hub
Modified:
Aug. 2, 2018, 11:20 p.m.
Reviewers:
Sebastian Noack, kzar
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

Issue 6832 - Easylist was not re-added if the anti-circumvention list existed

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed unrelated change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M lib/subscriptionInit.js View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4
hub
Aug. 2, 2018, 10:33 p.m. (2018-08-02 22:33:13 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29845576/diff/29845577/lib/subscriptionInit.js File lib/subscriptionInit.js (left): https://codereview.adblockplus.org/29845576/diff/29845577/lib/subscriptionInit.js#oldcode85 lib/subscriptionInit.js:85: Nit: Unrelated change.
Aug. 2, 2018, 10:47 p.m. (2018-08-02 22:47:41 UTC) #2
hub
updated patch https://codereview.adblockplus.org/29845576/diff/29845577/lib/subscriptionInit.js File lib/subscriptionInit.js (left): https://codereview.adblockplus.org/29845576/diff/29845577/lib/subscriptionInit.js#oldcode85 lib/subscriptionInit.js:85: On 2018/08/02 22:47:41, Sebastian Noack wrote: > ...
Aug. 2, 2018, 10:59 p.m. (2018-08-02 22:59:24 UTC) #3
Sebastian Noack
Aug. 2, 2018, 11:04 p.m. (2018-08-02 23:04:01 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld