Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(200)

Issue 29845767: Issue 6685 - Offer incremental filter list downloads

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 4 days ago by rhowell
Modified:
4 days, 15 hours ago
Reviewers:
Vasily Kuznetsov
CC:
Sebastian Noack
Base URL:
https://hg.adblockplus.org/python-abp/
Visibility:
Public.

Description

Issue 6685 - Offer incremental filter list downloads

Patch Set 1 #

Patch Set 2 : Use sets instead of ndiff, account for removal of special comments #

Patch Set 3 : Use namedtuple filter list objects instead of strings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -2 lines) Patch
M abp/filters/parser.py View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M abp/filters/renderer.py View 1 2 1 chunk +38 lines, -0 lines 0 comments Download
A tests/test_differ.py View 1 2 1 chunk +77 lines, -0 lines 0 comments Download

Messages

Total messages: 4
rhowell
1 week, 4 days ago (2018-08-03 01:58:27 UTC) #1
rhowell
On 2018/08/03 01:58:27, rhowell wrote: Hi Vasily! Wanted to check in and get some feedback ...
1 week, 4 days ago (2018-08-03 02:03:27 UTC) #2
Vasily Kuznetsov
On 2018/08/03 02:03:27, rhowell wrote: > On 2018/08/03 01:58:27, rhowell wrote: > > Hi Vasily! ...
1 week, 3 days ago (2018-08-03 17:39:27 UTC) #3
rhowell
4 days, 15 hours ago (2018-08-09 19:39:02 UTC) #4
It wasn't possible to use the namedtuple filter list objects in sets, because
they contain nested dicts that aren't hashable, so I'm storing strings into the
sets instead.

I also removed the checksum logic. Is this more what you were thinking? Unless
I'm missing something, I don't see much opportunity for using the other parsing
and rendering functions.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5