Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/content/elemHideEmulation.js

Issue 29847555: Noissue - Update comment on :-abp-properties() DOM dependence (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Created Aug. 4, 2018, 12:06 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/content/elemHideEmulation.js
===================================================================
--- a/lib/content/elemHideEmulation.js
+++ b/lib/content/elemHideEmulation.js
@@ -718,18 +718,18 @@
// do full processing.
if (!stylesheets && !mutations)
stylesheets = this.document.styleSheets;
// If there are any DOM mutations and any of the patterns depends on both
// style sheets and the DOM (e.g. -abp-has(-abp-properties)), find all the
// rules in every style sheet in the document, because we need to run
// querySelectorAll afterwards. On the other hand, if we only have patterns
- // that depend on either styles or DOM both not both
- // (e.g. -abp-properties or -abp-contains), we can skip this part.
+ // that depend on either styles or DOM both not both (e.g. -abp-contains),
+ // we can skip this part.
if (mutations && patterns.some(pattern => pattern.dependsOnStylesAndDOM))
stylesheets = this.document.styleSheets;
for (let stylesheet of stylesheets || [])
{
// Explicitly ignore third-party stylesheets to ensure consistent behavior
// between Firefox and Chrome.
if (!this.isSameOrigin(stylesheet))
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld