Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(402)

Issue 29849585: Issue 6835 - Add R support to python-abp (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by Tudor Avram
Modified:
1 month, 2 weeks ago
Reviewers:
Vasily Kuznetsov
CC:
kirill
Visibility:
Public.

Description

Issue 6835 - Add R support to python-abp

Patch Set 1 #

Total comments: 4

Patch Set 2 : Refactored tests #

Total comments: 1

Patch Set 3 : Small optimisation on tests #

Patch Set 4 : Updated REAME.md with R integration docs #

Total comments: 4

Patch Set 5 : Fixed consistency issues in README.md #

Unified diffs Side-by-side diffs Delta from patch set Stats (+261 lines, -0 lines) Patch
M README.md View 1 2 3 4 1 chunk +20 lines, -0 lines 0 comments Download
A abp/filters/rpy.py View 1 1 chunk +93 lines, -0 lines 0 comments Download
A tests/test_rpy.py View 1 2 1 chunk +148 lines, -0 lines 0 comments Download

Messages

Total messages: 10
Tudor Avram
Hi all, Here is the first (basic) implementation of the rPython layer from python-abp. Currently, ...
2 months, 1 week ago (2018-08-07 15:12:08 UTC) #1
Vasily Kuznetsov
Hi Tudor, It looks good in general. Perhaps we can add another function for converting ...
2 months, 1 week ago (2018-08-08 14:32:50 UTC) #2
Tudor Avram
Hi Vasily, I addressed your comments and refactores test_rpy.py. Thanks, Tudor. https://codereview.adblockplus.org/29849585/diff/29849586/abp/filters/rpy.py File abp/filters/rpy.py (right): ...
2 months, 1 week ago (2018-08-09 12:55:02 UTC) #3
Vasily Kuznetsov
LGTM so far (there's a minor comment about the tests, but it's too minor for ...
2 months ago (2018-08-16 16:00:52 UTC) #4
Tudor Avram
Hi Vasily, Thanks, just did the last change you suggested in the tests. Tudor.
2 months ago (2018-08-20 14:56:29 UTC) #5
Vasily Kuznetsov
On 2018/08/20 14:56:29, Tudor Avram wrote: > Hi Vasily, > > Thanks, just did the ...
1 month, 4 weeks ago (2018-08-21 15:02:33 UTC) #6
Tudor Avram
Hi Vasily and Kirill, I made the changes to README.md to document the R integration ...
1 month, 3 weeks ago (2018-08-29 11:47:09 UTC) #7
Vasily Kuznetsov
Hi Tudor and Kirill, I like the addition to the documentation and just have two ...
1 month, 2 weeks ago (2018-08-30 12:23:19 UTC) #8
Tudor Avram
Hi Vasily and Kirill, I addressed the comments related to the README. Thanks, Tudor. https://codereview.adblockplus.org/29849585/diff/29868573/README.md ...
1 month, 2 weeks ago (2018-08-31 10:17:54 UTC) #9
Vasily Kuznetsov
1 month, 2 weeks ago (2018-08-31 12:35:41 UTC) #10
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5