Issue 6841 - Avoid passing frameId of 0 to tabs.executeScript

lib/contentFiltering.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 162 matching lines @@
   code = compileScript(script, [snippetsLibrarySource]);
 
   executableCode.set(script, code);
   return code;
 }
 
 function executeScript(script, tabId, frameId)
 {
   try
   {
-    browser.tabs.executeScript(tabId, {
+    let details = {
       code: getExecutableCode(script),
-      frameId,
       matchAboutBlank: true,
       runAt: "document_start"
-    })
+    };
+
+    // Chrome <50 throws an exception if chrome.tabs.executeScript is called
+    // with a frameId of 0.
+    if (frameId != 0)
+      details.frameId = frameId;
+
+    browser.tabs.executeScript(tabId, details)
     .catch(error =>
     {
       // Sometimes a frame is added and removed very quickly, in such cases we
       // simply ignore the error.
       if (error.message == "The frame was removed.")
         return;
 
       // Sometimes the frame in question is just not found. We don't know why
       // this is exactly, but we simply ignore the error.
       if (/^No frame with id \d+ in tab \d+\.$/.test(error.message))
@@ skipping 67 matching lines @@
   updateFrameStyles(sender.page.id, sender.frame.id, message.selectors,
                     message.groupName, message.appendOnly);
 });
 
 fetch(browser.extension.getURL("/snippets.js"), {cache: "no-cache"})
 .then(response => response.ok ? response.text() : "")
 .then(text =>
 {
   snippetsLibrarySource = text;
 });