Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29851630: Issue 6844 - Update buildtools to 1b51de5f632c / 444c380 (Closed)

Created:
Aug. 9, 2018, 7:46 a.m. by tlucas
Modified:
Aug. 9, 2018, 9:57 a.m.
Reviewers:
kzar
Base URL:
https://hg.adblockplus.org/adblockpluschrome/file/cc94e6a12457
Visibility:
Public.

Description

Issue 6844 - Update buildtools to 1b51de5f632c / 444c380

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M dependencies View 1 chunk +1 line, -1 line 0 comments Download
M ensure_dependencies.py View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3
kzar
Otherwise LGTM https://codereview.adblockplus.org/29851630/diff/29851631/README.md File README.md (right): https://codereview.adblockplus.org/29851630/diff/29851631/README.md#newcode25 README.md:25: ### Switching sources between platforms I'm usually ...
Aug. 9, 2018, 9:32 a.m. (2018-08-09 09:32:20 UTC) #1
tlucas
Patch Set 2 * Undid changes to README.md https://codereview.adblockplus.org/29851630/diff/29851631/README.md File README.md (right): https://codereview.adblockplus.org/29851630/diff/29851631/README.md#newcode25 README.md:25: ### ...
Aug. 9, 2018, 9:42 a.m. (2018-08-09 09:42:35 UTC) #2
kzar
Aug. 9, 2018, 9:51 a.m. (2018-08-09 09:51:44 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld