Issue 29852555: Issue 6559 - Convert subscriptions property of Filter to a set

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29852555: Issue 6559 - Convert subscriptions property of Filter to a set (Closed)

Created:
Aug. 10, 2018, 2:12 p.m. by Manish Jethani

Modified:
Aug. 15, 2018, 6:58 p.m.

Reviewers:
kzar, hub

Base URL:
https://hg.adblockplus.org/adblockpluscore/

Visibility:
Public.

Description

This further reduces the initial heap size by ~2 MB. The reason this happens is that there are duplicate entries for some Subscription objects in some Filter objects. For example, this filter: ##.adblock_floating_message It occurs twice in the Adblock Warning Removal List, hence there are two entries in its subscriptions array for the same Subscription object. By using a Set we eliminate the duplicates. In a number of places we also don't have to check if the Subscription object already exists in the list before performing an operation like add or delete. I'm also seeing a very slight speed-up in the parsing/loading of the initial subscriptions.

Patch Set 1 #

Created: Aug. 10, 2018, 2:12 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -33 lines)			Patch
M	lib/filterClasses.js	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	lib/filterListener.js	View	2 chunks	+3 lines, -5 lines	0 comments	Download
M	lib/filterStorage.js	View	5 chunks	+13 lines, -20 lines	0 comments	Download
M	test/filterListener.js	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	test/filterStorage.js	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages