Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(104)

Issue 29852577: Issue 6847 - Add regular expression support to snippets (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by Manish Jethani
Modified:
1 year, 6 months ago
Reviewers:
hub
CC:
kzar
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -4 lines) Patch
M lib/content/snippets.js View 3 chunks +46 lines, -4 lines 0 comments Download

Messages

Total messages: 5
Manish Jethani
1 year, 6 months ago (2018-08-11 04:53:59 UTC) #1
Manish Jethani
Patch Set 1
1 year, 6 months ago (2018-08-11 05:12:33 UTC) #2
hub
I wish we had test for that part. Otherwise, LGTM
1 year, 6 months ago (2018-08-15 21:28:01 UTC) #3
Manish Jethani
On 2018/08/15 21:28:01, hub wrote: > I wish we had test for that part. There ...
1 year, 6 months ago (2018-08-15 21:49:35 UTC) #4
hub
1 year, 6 months ago (2018-08-16 01:32:08 UTC) #5
Message was sent while issue was closed.
On 2018/08/15 21:49:35, Manish Jethani wrote:
> On 2018/08/15 21:28:01, hub wrote:
> > I wish we had test for that part.
> 
> There are no tests for the snippet library unfortunately. I think we'll have
to
> take this on as a separate task.

Yes that's unfortunate.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5