Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29853561: Issue 6854 - Remove deprecated FilterNotifier methods (Closed)

Created:
Aug. 11, 2018, 2:43 p.m. by Manish Jethani
Modified:
Aug. 29, 2018, 12:59 p.m.
Reviewers:
hub
CC:
kzar
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -127 lines) Patch
M lib/filterClasses.js View 3 chunks +3 lines, -3 lines 0 comments Download
M lib/filterNotifier.js View 1 chunk +1 line, -56 lines 0 comments Download
M lib/filterStorage.js View 8 chunks +12 lines, -14 lines 0 comments Download
M lib/subscriptionClasses.js View 8 chunks +8 lines, -16 lines 0 comments Download
M lib/synchronizer.js View 1 chunk +1 line, -1 line 0 comments Download
M test/filterNotifier.js View 1 chunk +40 lines, -30 lines 1 comment Download
M test/filterStorage.js View 8 chunks +24 lines, -7 lines 1 comment Download

Messages

Total messages: 3
Manish Jethani
Aug. 11, 2018, 2:43 p.m. (2018-08-11 14:43:29 UTC) #1
Manish Jethani
Patch Set 1 https://codereview.adblockplus.org/29853561/diff/29853562/test/filterNotifier.js File test/filterNotifier.js (right): https://codereview.adblockplus.org/29853561/diff/29853562/test/filterNotifier.js#newcode73 test/filterNotifier.js:73: compareListeners(test, "addListener(listener1) again", [listener1, listener1]); Note ...
Aug. 11, 2018, 2:47 p.m. (2018-08-11 14:47:07 UTC) #2
hub
Aug. 28, 2018, 8:28 p.m. (2018-08-28 20:28:14 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld